Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n support in devconsole health checks components #7115

Merged
merged 1 commit into from Nov 12, 2020
Merged

i18n support in devconsole health checks components #7115

merged 1 commit into from Nov 12, 2020

Conversation

vikram-raj
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 5, 2020
@debsmita1
Copy link
Contributor

localize health-checks-probe-validation-utils.ts

@vikram-raj
Copy link
Member Author

localize health-checks-probe-validation-utils.ts

I added localize health-checks-probe-validation-utils.ts in PR #7139. as it has been used in 2 import flows.

rottencandy
rottencandy approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2020
@invincibleJai
Copy link
Member

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rottencandy, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit e37679e into openshift:master Nov 12, 2020
@vikram-raj vikram-raj deleted the odc-5081 branch November 12, 2020 08:01
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rottencandy rottencandy rottencandy approved these changes

@divyanshiGupta divyanshiGupta Awaiting requested review from divyanshiGupta

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@invincibleJai invincibleJai

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vikram-raj @debsmita1 @invincibleJai @openshift-ci-robot @rottencandy @spadgett @openshift-merge-robot