Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n support in devconsole helm components #7117

Merged
merged 1 commit into from Nov 25, 2020
Merged

i18n support in devconsole helm components #7117

merged 1 commit into from Nov 25, 2020

Conversation

vikram-raj
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Nov 5, 2020
@debsmita1
Copy link
Contributor

localize strings in concatVersions in helm-utils.ts
HelmReleaseRollbackForm.tsx -> FormGroup label, aria-label & resetLabel
HelmReleaseResourcesRow.tsx -> Link title
modify-helm-release.ts

jerolimov
jerolimov reviewed Nov 11, 2020
View reviewed changes
frontend/packages/dev-console/src/components/helm/form/HelmInstallUpgradeForm.tsx Outdated
@@ -140,7 +142,7 @@ const HelmInstallUpgradeForm: React.FC<FormikProps<FormikValues> & HelmInstallUp
isSubmitting={status?.isSubmitting || isSubmitting}
submitLabel={helmAction}
Copy link
Member

@jerolimov jerolimov Nov 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to translate the submitLabel as well. helmAction is an enum which we could not translate directly, so we need a mapping here from enum to label, or?

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can no translate this enum as it also use to show the form type of Install, Upgrade or Rollback.

Copy link
Member

@jerolimov jerolimov Nov 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's about

Suggested change
submitLabel={helmAction}
submitLabel={t(`devconsole~${helmAction}`)}

?

Not perfect but should work. Don't know if we have some other areas where we need to translate enums. But if I'm right the good thing is that if we add an enum the translation shows as label (helmaction) as fallback. In our case we need to add all three labels also if they doesn't existing 1:1 in sourcecode. (I mean, there is no reverse lookup like t(devconsole~Install))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same in HelmReleaseRollbackForm.tsx

@jerolimov
Copy link
Member

Test fails because of ✖ Update Annotation from empty value to value (1 failure)

/retest

@vikram-raj vikram-raj force-pushed the odc-5084 branch 2 times, most recently from c1e7743 to fb21aaf Compare November 11, 2020 18:16
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 16, 2020
jerolimov
jerolimov approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally and looks good. @debsmita1 are you also fine with your requested changes?

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2020
@invincibleJai
Copy link
Member

/approve

Verified the changes

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@vikram-raj
Copy link
Member Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
jerolimov
jerolimov approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@jerolimov jerolimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, jerolimov, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e20029f into openshift:master Nov 25, 2020
@vikram-raj vikram-raj deleted the odc-5084 branch November 25, 2020 04:40
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerolimov jerolimov jerolimov approved these changes

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

@christianvogt christianvogt Awaiting requested review from christianvogt

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@jerolimov jerolimov

@invincibleJai invincibleJai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@vikram-raj @debsmita1 @jerolimov @invincibleJai @openshift-bot @christianvogt @openshift-ci-robot @spadgett @openshift-merge-robot