New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1895430: Fix edit flow in case of custom template application #7121
Bug 1895430: Fix edit flow in case of custom template application #7121
Conversation
/assign @christianvogt |
ee8b096
to
fdc51f3
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, divyanshiGupta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@divyanshiGupta: All pull requests linked via external trackers have merged: Bugzilla bug 1895430 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.6 |
@divyanshiGupta: new pull request created: #7148 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5017
Analysis / Root cause:
User is not able to edit custom template application because we only add the user labels (which in this case are template specific labels) and pod labels to spec.template.metadata.label and specific spec.template.metadata.label labels are getting removed. Another reason is during edit we get the
imageStream
based on the value ofapp.kubernetes.io/instance
and if the respectiveimageStream
doesnt haveapp.kubernetes.io/instance
label the edit flow will not get theimageStream
to be updated. We will ask the user to addapp.kubernetes.io/instance
on theimageStream
. For more context - https://issues.redhat.com/browse/ODC-5017?focusedCommentId=15387232&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15387232Solution Description:
Preserve specific spec.template.metadata.label labels during edit.
Screen shots / Gifs for design review:
Unit test coverage report:
Browser conformance: