Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1895430: Fix edit flow in case of custom template application #7121

Merged

Conversation

divyanshiGupta
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/ODC-5017

Analysis / Root cause:
User is not able to edit custom template application because we only add the user labels (which in this case are template specific labels) and pod labels to spec.template.metadata.label and specific spec.template.metadata.label labels are getting removed. Another reason is during edit we get the imageStream based on the value of app.kubernetes.io/instance and if the respective imageStream doesnt have app.kubernetes.io/instance label the edit flow will not get the imageStream to be updated. We will ask the user to add app.kubernetes.io/instance on the imageStream. For more context - https://issues.redhat.com/browse/ODC-5017?focusedCommentId=15387232&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15387232

Solution Description:
Preserve specific spec.template.metadata.label labels during edit.

Screen shots / Gifs for design review:
Peek 2020-11-05 23-03

Unit test coverage report:

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@divyanshiGupta
Copy link
Contributor Author

/assign @christianvogt

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3150016 into openshift:master Nov 6, 2020
@divyanshiGupta divyanshiGupta changed the title Fix edit flow in case of custom template application Bug 1895430: Fix edit flow in case of custom template application Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1895430 has been moved to the MODIFIED state.

In response to this:

Bug 1895430: Fix edit flow in case of custom template application

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyanshiGupta
Copy link
Contributor Author

/cherrypick release-4.6

@openshift-cherrypick-robot

@divyanshiGupta: new pull request created: #7148

In response to this:

/cherrypick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants