Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2432: Add i18n externalized strings for events page #7130

Merged
merged 1 commit into from Dec 22, 2020
Merged

CONSOLE-2432: Add i18n externalized strings for events page #7130

merged 1 commit into from Dec 22, 2020

Conversation

jcaianirh
Copy link
Member

For: https://issues.redhat.com/browse/CONSOLE-2432

Externalize strings in home/events section

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 5, 2020
@jcaianirh jcaianirh changed the title CONSOLE-2432: Add i18n externalize strings for events page CONSOLE-2432: Add i18n externalized strings for events page Nov 5, 2020
@dtaylor113 dtaylor113 mentioned this pull request Nov 6, 2020
Closed
@jcaianirh
Copy link
Member Author

/retest

spadgett
spadgett reviewed Nov 11, 2020
View reviewed changes
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2020
@jcaianirh
Copy link
Member Author

@spadgett i think i've addressed all review comments here

@jcaianirh
Copy link
Member Author

/test frontend

@jcaianirh
Copy link
Member Author

/retest

@jcaianirh
Copy link
Member Author

/test analyze

rhamilto
rhamilto reviewed Dec 17, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor DRY nit.

frontend/public/components/events.jsx Outdated Show resolved Hide resolved
frontend/public/components/events.jsx Outdated Show resolved Hide resolved
@jcaianirh
Copy link
Member Author

@rhamilto updated thanks!

rhamilto
rhamilto approved these changes Dec 17, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for approvals

/assign @ahardin-rh @yapei @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2020
@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Dec 17, 2020
@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Dec 21, 2020
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Dec 21, 2020
@rhamilto
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2020
@pweil- pweil- added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 21, 2020
@pweil-
Copy link
Contributor

pweil- commented Dec 21, 2020

manually adding valid-bug until we work out openshift/release#14440 since the console team is piloting the no feature freeze effort and this PR has all acks, approvals, and lgtms

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@rhamilto
Copy link
Member

/lgtm cancel

Please squash.

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2020
@jcaianirh
Copy link
Member Author

@rhamilto squashed

@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcaianirh
Copy link
Member Author

/test analyze

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 91a5671 into openshift:master Dec 22, 2020
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@rhamilto rhamilto rhamilto approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@rhamilto rhamilto

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet