generic component to highlight any part of the ui #7131

nemesis09 · 2020-11-05T22:34:50Z

Fixes:
https://issues.redhat.com/browse/ODC-4999

Description:
Create a generic component to highlight any part of UI with animation

Screens:
highlight component behaviour ideal
Note: three components are highlighted simultaneously for illustration only.

highlight component behaviour when clicked anywhere on the ui after animation has started

highlight component behaviour autoscroll to bring component to highlight in viewport if it is hidden

guided tour behaviour unchanged with updated Spotlight component

Test Coverage:

Browser Conformance:

Firefox
Chrome
Safari
Edge

rohitkrai03 · 2020-11-06T18:59:32Z

frontend/packages/console-shared/src/components/highlight/Highlight.tsx

+    width,
+  };
+  return (
+    <Portal>


The implementation is exactly same as the Spotlight component from guided tour. Instead of creating a new one you should just move that one to console-shared and add some customization for this use case.

updated with customized spotlight component

christianvogt · 2020-11-10T22:28:38Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+          <div
+            className={cx({
+              'ocs-spotlight__element-highlight-animate': animate,
+              'ocs-spotlight__element-highlight-noanimate': !animate,
+            })}
+            style={style}


DRY. Store this component in a variable and render conditionally.

updated using variable.

lwrigh · 2020-11-11T13:44:40Z

@nemesis09 Here are the animation specifications from the final design doc:

Blink animation is triggered by click/tap initiating step
Blink animation is delayed start by 0.5 seconds ⬅️
Blink animation consists of (all at the same time and over 1.2 sec duration)
Scale: shape increases size from 100% to 150% ⬅️
Border width: from 4px to 8px ⬅️
Opacity: from 100% to 0%

I took a closer look at the GIF and CSS and I think the elements that are missing are the specifications with the arrows next to them. Let me know if you need me to take a closer look at any animation specifications.

Here's the link to the final design doc if you need to reference it: https://docs.google.com/document/d/1T41IzREwgfqR6NVpXI8e4psfkBR39gWt0eLfvA9pkGs/edit?usp=sharing

rohitkrai03 · 2020-11-12T15:58:56Z

/assign

nemesis09 · 2020-11-18T20:11:55Z

@nemesis09 Here are the animation specifications from the final design doc:

Blink animation is triggered by click/tap initiating step
Blink animation is delayed start by 0.5 seconds arrow_left
Blink animation consists of (all at the same time and over 1.2 sec duration)
Scale: shape increases size from 100% to 150% arrow_left
Border width: from 4px to 8px arrow_left
Opacity: from 100% to 0%

I took a closer look at the GIF and CSS and I think the elements that are missing are the specifications with the arrows next to them. Let me know if you need me to take a closer look at any animation specifications.

Here's the link to the final design doc if you need to reference it: https://docs.google.com/document/d/1T41IzREwgfqR6NVpXI8e4psfkBR39gWt0eLfvA9pkGs/edit?usp=sharing

updated animation addressing the suggested requirements. PTAL

lwrigh · 2020-11-18T20:21:56Z

@nemesis09 Here are the animation specifications from the final design doc:
Blink animation is triggered by click/tap initiating step
Blink animation is delayed start by 0.5 seconds arrow_left
Blink animation consists of (all at the same time and over 1.2 sec duration)
Scale: shape increases size from 100% to 150% arrow_left
Border width: from 4px to 8px arrow_left
Opacity: from 100% to 0%
I took a closer look at the GIF and CSS and I think the elements that are missing are the specifications with the arrows next to them. Let me know if you need me to take a closer look at any animation specifications.
Here's the link to the final design doc if you need to reference it: https://docs.google.com/document/d/1T41IzREwgfqR6NVpXI8e4psfkBR39gWt0eLfvA9pkGs/edit?usp=sharing

updated animation addressing the suggested requirements. PTAL

The updates you made @nemesis09 look good to me! From the GIFs it looks like the behaviors and timing work out well.

lwrigh · 2020-11-18T20:38:20Z

@mceledonia Here's the PR associated with the animated quick start hints. Feel free to take a look. The GIFs at the top of the PR are the most recent version of the implementation.

nemesis09 · 2020-11-18T21:03:49Z

/retest

sahil143 · 2020-11-20T16:12:53Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.scss

+@keyframes highlight {
+  0% {
+    opacity: 1;
+    border: var(--pf-global--BorderWidth--xl) solid var(--pf-global--palette--blue-200);


Why didn't we use box shadow here as shown in https://codesandbox.io/s/highlight-9oizs

the UX for animation was updated
please find the updated UX for animation here
Slack Conversation links:
https://coreos.slack.com/archives/C014NQG3H5L/p1604609753173100
https://coreos.slack.com/archives/C014NQG3H5L/p1604610208176400

christianvogt · 2020-11-20T22:37:39Z

@nemesis09 a few observations from your images:

While the highlight border animates, a border around the item should remain in place.
The animation spec listed here mentions nothing about the outline shrinking.
The border should remain for 10 seconds after the animation, without fading IMO, and then fade out quickly or simply disappear. Your animation looks like a 10second slow fade out.
Your 3rd gif shows that when the menu is scrolled, the outline fails to follow the nav item.
I believe the guided tour outline should be the same color as the quick start highlight now.

I'm waiting on @mceledonia to provide updates on the animation before reviewing the code.

mceledonia · 2020-11-23T15:02:35Z

I'll run through each step of the animation and add the transitions and timings in code styling. I'll also add some visual aids for each step.

For the animation of all hint borders:

The user clicks the text link to activate the hint border.
The border appears as two exact copies around the element, since they are two exact copies stacked on top of each other they just look like one. They should both Fade in over 0.4 seconds Right now they are static and do not move. The reason for 2 copies to appear is to achieve the desired animation effect described below.
After a brief delay of 1.2 seconds one copy of the border begins it's animation sequence. The animation sequence is as follows: increase in height and width of +50px over 1.2 seconds increase in border width from 4px to 8px over 1.2 seconds decrease in opacity/transparency from 100% to 0% over 1.2 seconds Note - These all happen simultaneously at the same time, and finish at the same time. They do not happen one after another.
The leftover static copy waits/delays 10 seconds and then triggers a fade out over 5 seconds

The spec for the starting border styling is the following:
Border width: 4px
Border color: $pf-color-blue-200: or #73bcf7

EDIT NOTE*** @nemesis09
I made a slight edit to the post and wanted to let you know.
Instead of scale increase +150%
I changed it to: scale/size increase top/bottom/left/right by +25px each
This way the expansion will always be consistent, whereas with a percentage the expansion will be larger on a larger item and smaller on a smaller one, we actually want them to always be the same.

christianvogt · 2020-11-23T18:29:51Z

Here's an updated implementation of the requested animation:
https://codesandbox.io/s/highlight-9oizs?file=/src/Highlight.css

Note that I'm currently working with @mceledonia to tweak the animation (eg border expansion from 4px -> 12px instead of 4px -> 8px)

christianvogt · 2020-11-23T18:30:48Z

@nemesis09 please use the same outline for both the guided tour and quick starts highlight.

christianvogt · 2020-11-24T17:28:05Z

(I modified the guided tour to test this)
You need to use popperjs to position the highlight so that it moves when the node underneath it moves. Otherwise this happens:

christianvogt · 2020-11-24T17:28:46Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.scss

@@ -0,0 +1,64 @@
+@keyframes expand {


Suggested change

@keyframes expand {

@keyframes co-spotlight-expand {

Shouldn't this be ocs-spotlight-expand?

yes it should be. my mistake

renamed to ocs-spotlight-expand

christianvogt · 2020-11-24T17:28:56Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.scss

+  }
+}
+
+@keyframes fade-in {


Suggested change

@keyframes fade-in {

@keyframes co-spotlight-fade-in {

@christianvogt @nemesis09 Shouldn't this be ocs-spotlight-expand since this is in console-shared package?

Not sure it matters... we have a poor consistency across the console for keyframes and their names having the appropriate module. I think it's because they are only ever used in the one file. I'm indifferent either way though.

yes it should be. my mistake

renamed to ocs-spotlight-expand

christianvogt · 2020-11-24T17:29:08Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.scss

+  }
+}
+
+@keyframes fade-out {


Suggested change

@keyframes fade-out {

@keyframes co-spotlight-fade-out {

@christianvogt @nemesis09 Shouldn't this be ocs-spotlight-expand since this is in console-shared package?

yes it should be. my mistake

renamed to ocs-spotlight-expand

christianvogt · 2020-11-24T17:31:44Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+  animate?: boolean;
+  hasBackdrop?: boolean;


There's a bug where if hasBackdrop === false && animate === false then this happens:

christianvogt · 2020-11-24T17:32:28Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+    />
+  );
+  return (
+    <Portal>


We will need to use popperjs instead so that the spotlight moves as the node underneath it moves.

using popperjs instead of portal

christianvogt · 2020-11-24T17:33:23Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+    ['--ocs-spotlight-top' as React.ReactText]: `${top}px`,
+    ['--ocs-spotlight-left' as React.ReactText]: `${left}px`,
+    ['--ocs-spotlight-height' as React.ReactText]: `${height}px`,
+    ['--ocs-spotlight-width' as React.ReactText]: `${width}px`,


Clean up dead code.

christianvogt · 2020-11-24T17:38:18Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+  animate?: boolean;
+  hasBackdrop?: boolean;


Combine these 2 props into one called interactive and add a description.
If interactive it will allow click through and animate. If !interactive it will display the background and prevent click through.

christianvogt · 2020-11-24T17:38:55Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+    const handleClick = () => setClicked(true);
+    document.addEventListener('mousedown', handleClick);
+    return () => {
+      document.removeEventListener('mousedown', handleClick);
+    };


Only listen for clicks if in interactive mode.
You should also make sure the click occurs on the target element and not anywhere on screen.

Suggested change

const handleClick = () => setClicked(true);

document.addEventListener('mousedown', handleClick);

return () => {

document.removeEventListener('mousedown', handleClick);

};

const handleClick = () => setClicked(true);

element.addEventListener('mousedown', handleClick);

return () => {

element.removeEventListener('mousedown', handleClick);

};

the goal for this function is to detect any click outside the link and stop the animation.

The solid rectangle hint persists until the user clicks somewhere else on the UI or waits the 10 seconds until it fades away.

although reading the uxd again, it seems the click-anywhere-to-disappear should only apply to the solid rectangle persisting after the expand animation. I'll check this with ux

christianvogt · 2020-11-24T17:40:13Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.scss

+  pointer-events: none;
+  position: absolute;
+  &__with-backdrop {
+    mix-blend-mode: hard-light;


This causes the blue for the guided tour to be slightly a different color than the one we actually want. Perhaps raise a separate issue for this since it was an issue before as well.

raised issue https://issues.redhat.com/browse/ODC-5178

andrewballantyne · 2020-11-26T08:07:07Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+      document.addEventListener('mousedown', handleClick);
+      return () => {
+        document.removeEventListener('mousedown', handleClick);


Suggested change

document.addEventListener('mousedown', handleClick);

return () => {

document.removeEventListener('mousedown', handleClick);

element.addEventListener('mousedown', handleClick);

return () => {

element.removeEventListener('mousedown', handleClick);

This was not updated...

I'm not sure if we need to check for click event on the element,
element is the component to highlight and the UXD says a click anywhere on the screen should stop the animation

I'll check with ux on the design again

I checked and you are right. They want it to disappear when clicking anywhere.

nemesis09 · 2020-11-30T15:05:34Z

/retest

andrewballantyne · 2020-11-30T15:40:48Z

/lgtm

andrewballantyne · 2020-11-30T16:15:31Z

/retest

andrewballantyne · 2020-11-30T16:38:24Z

Odd, pod didn't start...

1x kubelet: Successfully pulled image "quay.io/prometheus/busybox:latest" in 1m20.65114373s
2020/11/30 16:34:27 pod didn't start running within 15m0s:

Container artifacts is not ready with reason ContainerCreating

Container release is not ready with reason ContainerCreating

/retest

rohitkrai03

@nemesis09 I was testing this with guided tours by passing interactive prop to spotlight. I noticed some weird behaviors.

The outside click doesn't work on any part of the document. It only works when clicked on the popper part of the guided tour.
The borders on the help menu looks off. It looks okay without the interactive prop passed but the arrow is still off a bit from the center.

christianvogt · 2020-11-30T18:01:59Z

Interesting that the popover for help is also offset.

andrewballantyne · 2020-11-30T18:59:26Z

I don't understand how others are reproducing this situation lol... Christian on his Mac can reproduce... Aritra on Linux and Rohit on Linux -- but I can't on my Mac lol

Chrome

FF

andrewballantyne · 2020-11-30T19:01:25Z

The outside click doesn't work on any part of the document. It only works when clicked on the popper part of the guided tour.

@rohitkrai03 are you saying during Guided Tour you are expecting to click on the mask and exit? Because the interactive mode is false and thus the only way to close the modal is to close it via the x or finish the flow (or use one the exit at the start)

nemesis09 · 2020-11-30T19:20:17Z

@nemesis09 I was testing this with guided tours by passing interactive prop to spotlight. I noticed some weird behaviors.
* The outside click doesn't work on any part of the document. It only works when clicked on the popper part of the guided tour.

* The borders on the help menu looks off. It looks okay without the `interactive` prop passed but the arrow is still off a bit from the center.

This is odd. As far as I understand, there has been no substantial change in the spotlight as far as the implementation for Guided Tour is concerned.

andrewballantyne · 2020-11-30T19:23:29Z

This is odd. As far as I understand, there has been no substantial change in the spotlight as far as the implementation for Guided Tour is concerned.

@rohitkrai03 / @christianvogt / @nemesis09 Can you fire up any cluster (before this is merged) and check the Guided Tour? Is this a pre-existing issue? I obviously can't reproduce this 😞

nemesis09 · 2020-11-30T19:31:19Z

@nemesis09 I was testing this with guided tours by passing interactive prop to spotlight. I noticed some weird behaviors.
* The outside click doesn't work on any part of the document. It only works when clicked on the popper part of the guided tour.

* The borders on the help menu looks off. It looks okay without the `interactive` prop passed but the arrow is still off a bit from the center.

Update: I tried it out in the cluster, rather than localhost to check the differences. The offset in the arrow seems to be a pre-existing issue. I think this could be related to a similar behaviour in popover arrow that i noticed in the modals for cluster status card items, which later turned out to be a patternfly issue. here is the slack thread https://coreos.slack.com/archives/C6A3NV5J9/p1603962222473200

rohitkrai03 · 2020-11-30T19:39:37Z

The outside click doesn't work on any part of the document. It only works when clicked on the popper part of the guided tour.

@rohitkrai03 are you saying during Guided Tour you are expecting to click on the mask and exit? Because the interactive mode is false and thus the only way to close the modal is to close it via the x or finish the flow (or use one the exit at the start)

@andrewballantyne I tested guided tour after passing interactive prop to the Spotlight component. So my expectation was that clicking anywhere should stop the animation and fade out the border but it only works when clicked on the popover.

The below screenshot shows the original use of Spotlight without interactive prop. The arrow seems to be offset which is a pre-existing issue even before this PR but the border box around help is correctly placed.

The below screenshot shows the Spotlight with interactive prop passed so that it uses InteractiveSpotlight with animation. It has the border box around help icon offset to the icon but the arrow is now centered with the border box.

andrewballantyne · 2020-11-30T20:28:08Z

@andrewballantyne I tested guided tour after passing interactive prop to the Spotlight component. So my expectation was that clicking anywhere should stop the animation and fade out the border but it only works when clicked on the popover

Well that's disconcerting... I'll have to test this out once I am finished with my current task.

The below screenshot shows the original use of Spotlight without interactive prop. The arrow seems to be offset which is a pre-existing issue even before this PR but the border box around help is correctly placed.

The below screenshot shows the Spotlight with interactive prop passed so that it uses InteractiveSpotlight with animation. It has the border box around help icon offset to the icon but the arrow is now centered with the border box.

This is very confusing lol... I can't reproduce this in any fashion... I will have to try all the browsers under my disposal to see if I can reproduce this. Either way, I think we are addressing this post this PR merge.

christianvogt · 2020-11-30T20:32:33Z

frontend/packages/console-shared/src/components/spotlight/Spotlight.tsx

+};
+
+const Spotlight: React.FC<SpotlightProps> = ({ selector, interactive }) => {
+  const element = document.querySelector(selector);


Suggested change

const element = document.querySelector(selector);

const element = React.useMemo(() => document.querySelector(selector), [selector]);

christianvogt · 2020-11-30T20:34:20Z

frontend/packages/console-shared/src/components/spotlight/InteractiveSpotlight.tsx

+  const isInViewport = (elementToCheck: Element) => {
+    const rect = elementToCheck.getBoundingClientRect();
+    return (
+      rect.top >= 0 &&
+      rect.left >= 0 &&
+      rect.bottom <= (window.innerHeight || document.documentElement.clientHeight) &&
+      rect.right <= (window.innerWidth || document.documentElement.clientWidth)
+    );
+  };


This is a utility function. Move it out of the render closure.

christianvogt · 2020-11-30T20:34:54Z

frontend/packages/console-shared/src/components/spotlight/InteractiveSpotlight.tsx

+  const popperOptions: PopperOptions = {
+    modifiers: {
+      preventOverflow: {
+        enabled: false,
+      },
+    },
+  };


Make this a const outside of the render function.

andrewballantyne

/lgtm

christianvogt · 2020-11-30T21:20:49Z

/approve

openshift-ci-robot · 2020-11-30T21:21:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, christianvogt, nemesis09

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nemesis09 · 2020-12-01T00:42:44Z

/retest

openshift-bot · 2020-12-01T03:19:01Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-12-01T03:32:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2020

openshift-ci-robot requested review from rhamilto and zherman0 November 5, 2020 22:35

openshift-ci-robot added the component/shared Related to console-shared label Nov 5, 2020

rohitkrai03 suggested changes Nov 6, 2020

View reviewed changes

nemesis09 force-pushed the highlight-component branch from 6179017 to cc99d5c Compare November 10, 2020 20:09

openshift-ci-robot added the component/core Related to console core functionality label Nov 10, 2020

nemesis09 force-pushed the highlight-component branch from cc99d5c to 2848d13 Compare November 10, 2020 20:10

nemesis09 changed the title ~~[WIP]generic component to highlight any part of the ui~~ generic component to highlight any part of the ui Nov 10, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020

christianvogt reviewed Nov 10, 2020

View reviewed changes

nemesis09 force-pushed the highlight-component branch from 2848d13 to 71cba76 Compare November 11, 2020 12:39

openshift-ci-robot assigned rohitkrai03 Nov 12, 2020

nemesis09 force-pushed the highlight-component branch from 71cba76 to ddef86c Compare November 18, 2020 19:59

sahil143 reviewed Nov 20, 2020

View reviewed changes

nemesis09 force-pushed the highlight-component branch from ddef86c to c357569 Compare November 24, 2020 11:49

christianvogt reviewed Nov 24, 2020

View reviewed changes

nemesis09 force-pushed the highlight-component branch from c357569 to 1e004d0 Compare November 26, 2020 08:00

andrewballantyne reviewed Nov 26, 2020

View reviewed changes

nemesis09 force-pushed the highlight-component branch from 7d2cd99 to 516fe4c Compare November 30, 2020 15:24

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

rohitkrai03 suggested changes Nov 30, 2020

View reviewed changes

christianvogt reviewed Nov 30, 2020

View reviewed changes

generic component to highlight any part of the ui

383aa54

nemesis09 force-pushed the highlight-component branch from 516fe4c to 383aa54 Compare November 30, 2020 21:08

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

andrewballantyne approved these changes Nov 30, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2020

openshift-merge-robot merged commit 01588d5 into openshift:master Dec 1, 2020

spadgett added this to the v4.7 milestone Dec 9, 2020

	const element = document.querySelector(selector);
	const element = React.useMemo(() => document.querySelector(selector), [selector]);

generic component to highlight any part of the ui #7131

generic component to highlight any part of the ui #7131

Conversation

nemesis09 commented Nov 5, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lwrigh commented Nov 11, 2020

rohitkrai03 commented Nov 12, 2020

nemesis09 commented Nov 18, 2020

lwrigh commented Nov 18, 2020

lwrigh commented Nov 18, 2020

nemesis09 commented Nov 18, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

christianvogt commented Nov 20, 2020

mceledonia commented Nov 23, 2020 • edited

christianvogt commented Nov 23, 2020

christianvogt commented Nov 23, 2020

christianvogt commented Nov 24, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesis09 Nov 30, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesis09 Nov 26, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nemesis09 commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

rohitkrai03 left a comment

Choose a reason for hiding this comment

christianvogt commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

nemesis09 commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

nemesis09 commented Nov 30, 2020

rohitkrai03 commented Nov 30, 2020

andrewballantyne commented Nov 30, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrewballantyne left a comment

Choose a reason for hiding this comment

christianvogt commented Nov 30, 2020

openshift-ci-robot commented Nov 30, 2020

nemesis09 commented Dec 1, 2020

nemesis09 commented Nov 5, 2020 •

edited

mceledonia commented Nov 23, 2020 •

edited

nemesis09 Nov 30, 2020 •

edited

nemesis09 Nov 26, 2020 •

edited