Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1890104: update apiVersion for eventing resources wrt serverless 1.10 #7134

Merged

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Nov 6, 2020

Fixes:
https://issues.redhat.com/browse/ODC-5093

Analysis / Root cause:
With serverless 0.10 latest supported versions got updated

Solution Description:
Update the apiVersion for eventing resources

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: This pull request references Bugzilla bug 1890104, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1890104: update apiVersion for eventing resources wrt serverless 1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the component/knative Related to knative-plugin label Nov 6, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: This pull request references Bugzilla bug 1890104, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1890104: update apiVersion for eventing resources wrt serverless 1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karthikjeeyar
Copy link
Contributor

Verified locally, works fine
/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit fc0b2f1 into openshift:master Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: All pull requests linked via external trackers have merged:

Bugzilla bug 1890104 has been moved to the MODIFIED state.

In response to this:

Bug 1890104: update apiVersion for eventing resources wrt serverless 1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@invincibleJai
Copy link
Member Author

/cherry-pick release-4.6

@openshift-cherrypick-robot

@invincibleJai: #7134 failed to apply on top of branch "release-4.6":

Applying: update apiVersion for eventing resources wrt serverless 1.10
Using index info to reconstruct a base tree...
M	frontend/packages/knative-plugin/src/components/add/event-sources/ApiServerSection.tsx
M	frontend/packages/knative-plugin/src/models.ts
M	frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
Falling back to patching base and 3-way merge...
Auto-merging frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
Auto-merging frontend/packages/knative-plugin/src/models.ts
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/models.ts
Auto-merging frontend/packages/knative-plugin/src/components/add/event-sources/ApiServerSection.tsx
CONFLICT (content): Merge conflict in frontend/packages/knative-plugin/src/components/add/event-sources/ApiServerSection.tsx
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update apiVersion for eventing resources wrt serverless 1.10
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants