Topology, fetch jobs for cronjobs when necessary

[jeff-phillips-18]

Fixes:
https://issues.redhat.com/browse/ODC-5115

Solution Description:
Remove jobs from OverviewItem type. Add hook to retrieve jobs for a given cronjob resource. Update instances to use hooks rather than fields in the OverviewItem type.

Non-Functional Change

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind cleanup

[jerolimov]

Suggested change

	const [loadError, setLoadError] = React.useState<string>('');
	const [loadError, setLoadError] = React.useState<string>(null);

[jerolimov]

@jeff-phillips-18 Tested this with the CronJob example below and got an error in pods-overview.tsx#L254-L257 because PodsOverviewMultiple prop podResources is undefined.

apiVersion: batch/v1beta1
kind: CronJob
metadata:
  name: example
  namespace: christoph-test
spec:
  schedule: '@daily'
  jobTemplate:
    spec:
      template:
        spec:
          containers:
            - name: hello
              image: busybox
              args:
                - /bin/sh
                - '-c'
                - date; echo Hello from the Kubernetes cluster
          restartPolicy: OnFailure

So you need to return jobs state in useJobsForCronJobWatcher with default [] or ensure that PodsOverviewMultiple handles this case.

edit: I see the benefit of using a default as well as an check in PodsOverviewMultiple. If you prefer the default we can use also the benefit of the "" default for loadError, in that case let us use setLoadError("") if there is no error.

[jeff-phillips-18]

Thanks @jerolimov, updated.

[dtaylor113]

/lgtm

[jerolimov]

I personally would go with this, but its okay 😏

Suggested change

	let updatedPods = podResources?.length
	? podResources.reduce((acc, resource) => {
	acc.push(...getPodsForResource(resource, resources));
	return acc;
	}, [])
	: [];
	let updatedPods = podResources?.reduce((acc, resource) => {
	acc.push(...getPodsForResource(resource, resources));
	return acc;
	}, []) ?? [];

[jerolimov]

Verified locally that it did not crash anymore, changed to setLoadError(""), has already lgtm, and I would give it as well 👍

/lgtm

[rohitkrai03]

/approve

[jeff-phillips-18]

Rebased

[jeff-phillips-18]

rebased again

[andrewballantyne]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, dtaylor113, jeff-phillips-18, jerolimov, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment