Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1872095: Consistency display resource details in a two equal column layout #7166

Merged

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented Nov 9, 2020

Currently the majority of resource detail pages use an equal two column structure to display content, though not all resources have data displayed in the rightmost column. While other pages utilize a single column structure, this has resulted in different display widths of the label input and edit component. Bugzilla 1872095 was opened for this issue.

Since the majority of pages utilize a two column structure, I found and updated the remaining pages to be utilize a two column layout.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1872095

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 9, 2020
@rhamilto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit a9f101d into openshift:master Nov 10, 2020
@sg00dwin sg00dwin changed the title Consistency display resource details in a two equal column layout Bug 1872095 Consistency display resource details in a two equal column layout Nov 11, 2020
@sg00dwin
Copy link
Member Author

/bugzilla refresh

@sg00dwin sg00dwin changed the title Bug 1872095 Consistency display resource details in a two equal column layout Bug 1872095: Consistency display resource details in a two equal column layout Nov 11, 2020
@openshift-ci-robot
Copy link
Contributor

@sg00dwin: All pull requests linked via external trackers have merged:

Bugzilla bug 1872095 has been moved to the MODIFIED state.

In response to this:

Bug 1872095: Consistency display resource details in a two equal column layout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
@sg00dwin sg00dwin deleted the label-edit-bug1872095 branch June 15, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants