Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1888870: Remove resolveCompletionItem from yaml editor since it's not needed #7167

Merged
merged 1 commit into from Nov 10, 2020
Merged

Bug 1888870: Remove resolveCompletionItem from yaml editor since it's not needed #7167

merged 1 commit into from Nov 10, 2020

Conversation

JPinkney
Copy link
Contributor

This PR removes the resolveCompletionItem from the yaml editor since it's not actually needed and is causing errors.

Associated issue: https://bugzilla.redhat.com/show_bug.cgi?id=1888870

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Nov 10, 2020
@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @JPinkney. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JPinkney, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@rhamilto
Copy link
Member

/retest

@rhamilto rhamilto changed the title Remove resolveCompletionItem from yaml editor since it's not needed Bug 1888870: Remove resolveCompletionItem from yaml editor since it's not needed Nov 10, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

@JPinkney: This pull request references Bugzilla bug 1888870, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1888870: Remove resolveCompletionItem from yaml editor since it's not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 031a87a into openshift:master Nov 10, 2020
@openshift-ci-robot
Copy link
Contributor

@JPinkney: All pull requests linked via external trackers have merged:

Bugzilla bug 1888870 has been moved to the MODIFIED state.

In response to this:

Bug 1888870: Remove resolveCompletionItem from yaml editor since it's not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JPinkney JPinkney deleted the remove-resolve-completion-item branch November 11, 2020 02:42
@spadgett spadgett added this to the v4.7 milestone Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants