Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1896302: Fix 4.6 test failures #7169

Merged
merged 1 commit into from Dec 2, 2020
Merged

Bug 1896302: Fix 4.6 test failures #7169

merged 1 commit into from Dec 2, 2020

Conversation

gouyang
Copy link
Contributor

@gouyang gouyang commented Nov 10, 2020

This will fix/improve below test failures:

  1. fix migration tests as it require rootdisk's accessMode is RXW.
  2. fix cloud-init test as the wizard procedure to custom script instead of form.
  3. increase vm stop timeout to 220 which is larger than vm's termination grace period 210s.
  4. add checking to look for VM login prompt when starts a VM.
  5. change container image from 'fedora-cloud-registry-disk-demo' to 'fedora-cloud-container-disk-demo'
  6. fix network dialog test failures due to new UI changes.
  7. add test ID for guest data test.
  8. move boot-order test to bottom in next-run-configuration test as it has side effects.
  9. add a check for loading vm disk page.

TODO: add test ID for test vm.next.run.configuration.scenario.ts.

@openshift-ci-robot
Copy link
Contributor

@gouyang: This pull request references Bugzilla bug 1896302, which is invalid:

  • expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1896302: Fix 4.6 test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin labels Nov 10, 2020
@gouyang gouyang force-pushed the fix_46_test_failure branch 2 times, most recently from 710b615 to 2740be5 Compare November 11, 2020 12:03
@gouyang gouyang mentioned this pull request Nov 11, 2020
Merged
@gouyang gouyang force-pushed the fix_46_test_failure branch 8 times, most recently from 3f290e8 to 8059283 Compare November 17, 2020 10:18
@gouyang
Copy link
Contributor Author

gouyang commented Nov 17, 2020

More fixes:

  1. test ID added for test vm.next.run.configuration.scenario.ts.
  2. close wizard in wizard last test so it not affect other test.
  3. adjust cdi test as it changes again.
  4. disable to start a PXE vm.

@suomiy this is ready for review, could you take a look at it once again.

atiratree
atiratree reviewed Nov 18, 2020
View reviewed changes
frontend/packages/kubevirt-plugin/integration-tests/tests/models/virtualMachine.ts Outdated Show resolved Hide resolved
frontend/packages/kubevirt-plugin/integration-tests/views/wizard.view.ts
@@ -89,8 +89,5 @@ export const tableRowAttribute = async (name: string, columnIndex: number): Prom
.get(columnIndex)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could move these table and kebab selectors as well

Copy link
Contributor Author

@gouyang gouyang Nov 19, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are very similar files like uiResource.view and kubevirtUIResource.view, I'd like to go through them in a new PR, as this one is focusing on fixing failures.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

frontend/packages/kubevirt-plugin/integration-tests/tests/models/baseVirtualMachine.ts Outdated Show resolved Hide resolved
@atiratree
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2020
@atiratree
Copy link
Member

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@suomiy: This pull request references Bugzilla bug 1896302, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@atiratree
Copy link
Member

/hold

until #7221 is merged

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2020
@gouyang
Copy link
Contributor Author

gouyang commented Nov 28, 2020

/retest

@gouyang
Copy link
Contributor Author

gouyang commented Nov 30, 2020

@suomiy I removed the expect part in vm actions, so it can pass the tests for the moment.
Will add them back when 'expect' is ready.

@atiratree
Copy link
Member

@gouyang ok, can you please at least comment out the places where expect would be used instead of deleting them? And adding a TODO marker so we can easily return to this later?

fyi, the expect PRs openshift/release#13715 and #7306 looked promising, but it seems analyze script is broken and need to be fixed before this can get merged

@gouyang
Copy link
Contributor Author

gouyang commented Dec 1, 2020

@gouyang ok, can you please at least comment out the places where expect would be used instead of deleting them? And adding a TODO marker so we can easily return to this later?

Comment it out instead of removing it and adding a TODO there.

@gouyang
Copy link
Contributor Author

gouyang commented Dec 1, 2020

/test e2e-gcp-console

@atiratree
Copy link
Member

/hold cancel
/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, suomiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gouyang
Copy link
Contributor Author

gouyang commented Dec 2, 2020

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot merged commit 493f049 into openshift:master Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

@gouyang: All pull requests linked via external trackers have merged:

Bugzilla bug 1896302 has been moved to the MODIFIED state.

In response to this:

Bug 1896302: Fix 4.6 test failures

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@gouyang gouyang deleted the fix_46_test_failure branch April 6, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree requested changes

@glekner glekner Awaiting requested review from glekner

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gouyang @openshift-ci-robot @atiratree @openshift-bot @spadgett @openshift-merge-robot