Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2456: Update OperatorHub detail view to include default catalog sources #7191

Merged
merged 1 commit into from Jan 22, 2021
Merged

CONSOLE-2456: Update OperatorHub detail view to include default catalog sources #7191

merged 1 commit into from Jan 22, 2021

Conversation

harishsurf
Copy link
Contributor

@harishsurf harishsurf commented Nov 11, 2020 •
edited by openshift-ci-robot

This change adds the default catalog sources section to the operator hub "Detail" view (Cluster Settings -> Global Configuration -> OperatorHub) providing an option to enable/disable each of the default catalog sources through a modal as shown in the image below

toggle

CONSOLE-2456

Signed-off-by: Harish hgovinda@redhat.com

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Nov 11, 2020
@harishsurf harishsurf force-pushed the operator-detail branch 2 times, most recently from c32c7a3 to af9db21 Compare November 17, 2020 18:38
@harishsurf harishsurf changed the title [WIP] Update OperatorHub detail view to include default catalog sources Update OperatorHub detail view to include default catalog sources Nov 17, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 17, 2020
@harishsurf
Copy link
Contributor Author

/retest

TheRealJon
TheRealJon approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small tweaks

...end/packages/operator-lifecycle-manager/src/components/modals/edit-default-sources-modal.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/modals/edit-default-sources-modal.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-details.tsx Outdated Show resolved Hide resolved
frontend/public/components/utils/details-item.tsx Outdated Show resolved Hide resolved
frontend/public/components/utils/details-item.tsx Outdated Show resolved Hide resolved
frontend/public/components/utils/details-item.tsx Outdated Show resolved Hide resolved
...end/packages/operator-lifecycle-manager/src/components/operator-hub/operator-hub-details.tsx Outdated Show resolved Hide resolved
@harishsurf harishsurf force-pushed the operator-detail branch 2 times, most recently from d350d16 to 5b9b336 Compare December 1, 2020 17:32
TheRealJon
TheRealJon approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small nit, but I'm okay to merge this as is.
/lgtm
/approve

frontend/public/components/utils/details-item.tsx Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-merge-robot
Copy link
Contributor

@harishsurf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 6915545 link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member

spadgett commented Dec 8, 2020

/approve
/hold for QE / docs / CEE approval

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 8, 2020
@harishsurf
Copy link
Contributor Author

/assign @yapei @ahardin-rh @sferich888

@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Dec 15, 2020
@yapei
Copy link
Contributor

yapei commented Dec 18, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Dec 18, 2020
@sferich888
Copy link

/label px-approved
/unassign @sferich888

@TheRealJon
Copy link
Member

/hold

@spadgett I'm not sure what's happening with this. Looking at the test history, all the tests passed on the last run, but for some reason this retest was still triggered.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2021
@TheRealJon
Copy link
Member

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

12 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2021
@spadgett
Copy link
Member

@TheRealJon Can you help rebase?

@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 20, 2021
@harishsurf @TheRealJon
Include enabling/disabling default catalog sources in
7da9e72 
operator-hub detail view

Signed-off-by: Harish <hgovinda@redhat.com>
spadgett
spadgett approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harishsurf, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

/retest

1 similar comment
@TheRealJon
Copy link
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit 88a16b1 into openshift:master Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealJon TheRealJon TheRealJon approved these changes

@spadgett spadgett spadgett approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

Assignees

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

@TheRealJon TheRealJon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet