Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use console.flag/model extension in console-app package #7231

Merged
merged 1 commit into from Dec 1, 2020
Merged

Use console.flag/model extension in console-app package #7231

merged 1 commit into from Dec 1, 2020

Conversation

vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Nov 16, 2020 •
edited

  • Add empty console-extensions.json to all static plugins.
  • Use dynamic console.flag/model extension in @console/app package.
  • Update static and dynamic plugin README files.

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk labels Nov 16, 2020
@openshift-ci-robot openshift-ci-robot added the component/insights Related to insights plugin label Nov 16, 2020
@vojtechszocs
Copy link
Contributor Author

cc @spadgett @christianvogt @jelkosz

@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

I did regression testing of OLM features and all work well

@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Nov 25, 2020
@christianvogt
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 25, 2020
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@christianvogt
Copy link
Contributor

/hold cancel

@vojtechszocs please rebase

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 27, 2020
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 27, 2020
@vojtechszocs vojtechszocs changed the title Use console.flag/model extension in all Console plugins Use console.flag/model extension in console-app package Nov 27, 2020
@vojtechszocs
Copy link
Contributor Author

@vojtechszocs please rebase

Done, scope narrowed to @console/app package, we can update the rest on per-plugin basis.

@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3d9c22b into openshift:master Dec 1, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 Awaiting requested review from afreen23

@christianvogt christianvogt Awaiting requested review from christianvogt

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dev-console Related to dev-console component/insights Related to insights plugin component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/lso Related to local-storage-operator-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vojtechszocs @yapei @christianvogt @openshift-ci-robot @spadgett @openshift-merge-robot