Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create new test to verify logged-in users #7238

Merged
merged 2 commits into from Nov 26, 2020
Merged

create new test to verify logged-in users #7238

merged 2 commits into from Nov 26, 2020

Conversation

omril-redhat
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Nov 17, 2020
@openshift-ci-robot
Copy link
Contributor

Hi @omril-redhat. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 17, 2020
@yaacov
Copy link
Member

yaacov commented Nov 22, 2020

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 22, 2020
@yaacov
Copy link
Member

yaacov commented Nov 22, 2020

/retest

@gouyang
Copy link
Contributor

gouyang commented Nov 23, 2020

It would be better if checking the log in user in details tab as well.

@omril-redhat
Copy link
Contributor Author

/retest

@gouyang
Copy link
Contributor

gouyang commented Nov 24, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@omril-redhat
Copy link
Contributor Author

/assign @yaacov

@gouyang
Copy link
Contributor

gouyang commented Nov 24, 2020

@omril-redhat One more thing, please add the ID back to the test.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@omril-redhat
Copy link
Contributor Author

/retest

@yaacov
Copy link
Member

yaacov commented Nov 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2020
@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/dev-console Related to dev-console component/olm Related to OLM component/shared Related to console-shared and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 25, 2020
@omril-redhat
create new test to verify logged-in users
8f2bcb2 
removed unused container defenition

fixing tests after review

revert changes on expect-file-exists.sh

remove seperations

added missing test for the vmdtails screen

renove restart from vm, fixed linter

un-comment one expect step

added polarion tests cases

removed empty line

remove empty space
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 25, 2020
@yaacov
Copy link
Member

yaacov commented Nov 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@gouyang
Copy link
Contributor

gouyang commented Nov 25, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 25, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gouyang, omril-redhat, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yaacov
Copy link
Member

yaacov commented Nov 25, 2020

/retest

1 similar comment
@yaacov
Copy link
Member

yaacov commented Nov 25, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit a1f84ec into openshift:master Nov 26, 2020
@omril-redhat omril-redhat deleted the guest-agent-login-test branch November 29, 2020 09:16
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouyang gouyang gouyang left review comments

@yaacov yaacov yaacov left review comments

@mareklibra mareklibra Awaiting requested review from mareklibra

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@gouyang gouyang

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/olm Related to OLM component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@omril-redhat @openshift-ci-robot @yaacov @gouyang @openshift-bot @spadgett @openshift-merge-robot