Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2477: Improve OperatorHub -> Sources view #7259

Merged
merged 1 commit into from Dec 8, 2020
Merged

CONSOLE-2477: Improve OperatorHub -> Sources view #7259

merged 1 commit into from Dec 8, 2020

Conversation

harishsurf
Copy link
Contributor

This change modifies operator-hub->Sources tab.
Jira: https://issues.redhat.com/browse/CONSOLE-2477

The Sources tab list view now includes 2 new columns for the Catalog Sources:
Status and Registry Poll Interval

Kebab Action menu changes:
For default sources: Only the existing Disable and Edit CatalogSource
For custom sources: The menus match the Actions menu in the Catalog Source

sources_tab

Signed-off-by: Harish hgovinda@redhat.com

@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Nov 18, 2020
@harishsurf harishsurf changed the title Modify OperatorHub -> Sources tab include new columns and Kebab action items feat: Improve OperatorHub -> Sources view Nov 18, 2020
spadgett
spadgett reviewed Nov 19, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harishsurf

frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/catalog-source.tsx Outdated Show resolved Hide resolved
@spadgett spadgett changed the title feat: Improve OperatorHub -> Sources view CONSOLE-2477: Improve OperatorHub -> Sources view Nov 19, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 19, 2020
@harishsurf
Copy link
Contributor Author

/retest

@harishsurf
Include additional columns in catsrc list view
42e2528 
and change Kebab action menu

Signed-off-by: Harish <hgovinda@redhat.com>
spadgett
spadgett approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 24, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harishsurf, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

QE added test case and tested locally on a cluster-bot cluster, no issues found, detail verification steps can be found from test case

@yapei
Copy link
Contributor

yapei commented Nov 25, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Nov 25, 2020
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Nov 30, 2020
@harishsurf
Copy link
Contributor Author

/test e2e-gcp-console

@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Dec 2, 2020
@harishsurf
Copy link
Contributor Author

/test e2e-gcp-console

@spadgett
Copy link
Member

spadgett commented Dec 7, 2020

Removing the hold since we're below our SLO.

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit afe5013 into openshift:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@harishsurf @openshift-ci-robot @yapei @ahardin-rh @sferich888 @spadgett @openshift-bot @openshift-merge-robot