Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2485: Add Cypress descriptors test #7261

Merged

Conversation

rhamilto
Copy link
Member

@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Nov 18, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2020
@@ -11,7 +11,6 @@ declare global {
byTestDropDownMenu(selector: string): Chainable<Element>;
byTestOperatorRow(selector: string): Chainable<Element>;
byTestSectionHeading(selector: string): Chainable<Element>;
byTestDropdownMenu(selector: string): Chainable<Element>;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mistakenly duplicated this in #7214

@rhamilto
Copy link
Member Author

/retest

@rhamilto
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member Author

/retest

@rhamilto rhamilto force-pushed the cypress-olm-descriptors branch 2 times, most recently from a21200f to f080650 Compare November 19, 2020 14:06
@rhamilto rhamilto changed the title Add Cypress descriptors test CONSOLE-2485: Add Cypress descriptors test Nov 19, 2020
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 8953145 into openshift:master Nov 20, 2020
@rhamilto rhamilto deleted the cypress-olm-descriptors branch November 20, 2020 12:32
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants