Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONSOLE-2391: Monitoring: Add i18n for Metrics and Dashboards pages #7266

Merged
merged 1 commit into from Dec 7, 2020

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Nov 19, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added component/monitoring Related to monitoring approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 19, 2020
@spadgett spadgett changed the title Monitoring: Add i18n for Metrics and Dashboards pages CONSOLE-2391: Monitoring: Add i18n for Metrics and Dashboards pages Nov 19, 2020
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2020
Copy link
Contributor

@dtaylor113 dtaylor113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@spadgett spadgett added this to the v4.7 milestone Nov 19, 2020
@schituku
Copy link

schituku commented Nov 20, 2020

hi, the test failed. both pages are not getting translated.
steps:
launch a cluster bot for the pr -- "launch openshift/console #7266 aws"
change language preferences to other than english
check Monitoring>Dashboards or Metrics. No translation.
attached screenshot.
Screenshot from 2020-11-20 08-39-05
/cc @yapei

@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Nov 20, 2020
@kyoto
Copy link
Member Author

kyoto commented Nov 21, 2020

@schituku That is expected because the actual string translations have not been added yet. This PR just makes the strings available for translating, but doesn't include the actual translations.

@yanpzhan
Copy link
Contributor

yanpzhan commented Nov 23, 2020

@kyoto Won't those chart titles be marked for translation on dashboards page?
Screenshot from 2020-11-23 19-16-15

@spadgett
Copy link
Member

@yanpzhan No, the dashboard content itself will not be translated at this time. Those are defined in config maps contributed by the monitoring operator and are out of scope for the initial i18n work. What you have in the screenshot is what I would expect.

@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Nov 24, 2020
@sferich888
Copy link

@yanpzhan No, the dashboard content itself will not be translated at this time. Those are defined in config maps contributed by the monitoring operator and are out of scope for the initial i18n work. What you have in the screenshot is what I would expect.

If this is the case we need to make sure the release notes for i18n denotes this. @codyhoag can you make sure that we capture this in some way?

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Dec 2, 2020
@spadgett
Copy link
Member

spadgett commented Dec 2, 2020

@yanpzhan No, the dashboard content itself will not be translated at this time. Those are defined in config maps contributed by the monitoring operator and are out of scope for the initial i18n work. What you have in the screenshot is what I would expect.

@ahardin-rh -- @sferich888 suggested we should release note this. There are a few other places where things won't be translated as well such as content coming from operators in OperatorHub.

@codyhoag
Copy link

codyhoag commented Dec 2, 2020

I have added this to the release notes tracker so we don't miss this openshift/openshift-docs#26801 (comment). @ahardin-rh feel free to mark it as done in the tracker if you take care of the release note. Thanks!

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@kyoto
Copy link
Member Author

kyoto commented Dec 3, 2020

Rebased

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

We'll need to wait until our bugs are under our SLO before we can merge.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtaylor113, kyoto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spadgett
Copy link
Member

spadgett commented Dec 7, 2020

Removing the hold since we're below our SLO.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2020
@spadgett
Copy link
Member

spadgett commented Dec 7, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5718965 into openshift:master Dec 7, 2020
@kyoto kyoto deleted the query-browser-i18n branch December 8, 2020 01:28
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/monitoring Related to monitoring docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet