Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to specify nav section ordering by plugins #7275

Merged
merged 1 commit into from Nov 21, 2020
Merged

Add ability to specify nav section ordering by plugins #7275

merged 1 commit into from Nov 21, 2020

Conversation

jeff-phillips-18
Copy link
Member

Fixes:
https://issues.redhat.com/browse/ODC-5153

Solution Description:
Update the extension definition for NavItem to change sections to contain an id as well as a name.
Remove groups option, use section w/o a name to specify a title-less section.
Allow specifications of insertBefore and insertAfter fields for sections.
Update existing definitions.

Browser conformance:

  • [x ] Chrome
  • Firefox
  • Safari
  • Edge

/kind feature

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. component/core Related to console core functionality component/dev-console Related to dev-console labels Nov 19, 2020
@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk labels Nov 19, 2020
@jeff-phillips-18
Copy link
Member Author

/hold
sections should be specified explicitly and need to rethink ordering algorithm

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2020
@jeff-phillips-18
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
christianvogt
christianvogt reviewed Nov 20, 2020
View reviewed changes
frontend/packages/knative-plugin/src/plugin.tsx Outdated
Comment on lines 136 to 142
flags: {
required: [
FLAG_KNATIVE_SERVING_SERVICE,
FLAG_KNATIVE_SERVING_REVISION,
FLAG_KNATIVE_SERVING_ROUTE,
],
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need flags here for the section since the individual items that show up will be flagged instead.

@christianvogt
Copy link
Contributor

Insertion sorting and sections work as expected.
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2020
@christianvogt
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, jeff-phillips-18

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 89edf71 into openshift:master Nov 21, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
@jeff-phillips-18 jeff-phillips-18 deleted the section-ordering branch December 2, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianvogt christianvogt christianvogt left review comments

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

@debsmita1 debsmita1 Awaiting requested review from debsmita1

Assignees

@christianvogt christianvogt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/knative Related to knative-plugin component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/network-attachment-definition Related to network-attachment-definition component/noobaa Related to noobaa-storage-plugin component/olm Related to OLM component/sdk Related to console-plugin-sdk kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@jeff-phillips-18 @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot