Convert Hide Alert Checks from localStorage to user settings #7282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rottencandy
force-pushed
the
healthcheck-usersettings
branch
2 times, most recently
from
07e7f7a
to
ce3e025
Compare
frontend/packages/console-shared/src/components/health-checks/HealthChecksAlert.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/console-shared/src/components/health-checks/HealthChecksAlert.tsx
Outdated
Show resolved
Hide resolved
rottencandy
force-pushed
the
healthcheck-usersettings
branch
2 times, most recently
from
7b4062a
to
f06d66e
Compare
jerolimov
reviewed
Nov 25, 2020
| @@ -30,6 +30,8 @@ export const UNASSIGNED_APPLICATIONS_KEY = '#UNASSIGNED_APP#'; | |||
| // Prefix our localStorage items to avoid conflicts if another app ever runs on the same domain. | |||
| export const STORAGE_PREFIX = 'bridge'; | |||
|
|
|||
| export const CONFIGMAP_PREFIX = 'console'; | |||
There was a problem hiding this comment.
@rottencandy @invincibleJai Can / should we call this USERSETTINGS_PREFIX ? 😄
jerolimov
reviewed
Nov 25, 2020
| }); | ||
| [settings, callback] = useUserSettings('devconsole.topology.key', 'list'); | ||
| expect(callback).toBeDefined(); | ||
| }); |
There was a problem hiding this comment.
This is part of Sahil's PR
rottencandy
force-pushed
the
healthcheck-usersettings
branch
from
f06d66e
to
39e9f53
Compare
openshift-ci-robot
added
the
needs-rebase
rottencandy
force-pushed
the
healthcheck-usersettings
branch
from
39e9f53
to
67e842b
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/lgtm Verified the changes , works as expected |
|
/assign @christianvogt |
andrewballantyne
approved these changes
Nov 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, invincibleJai, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story:
https://issues.redhat.com/browse/ODC-5106
Description:
Use
useUserSettingshook to store the local storage data into a config map.Browser conformance: