Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal3 plugin i18n i #7300

Merged
merged 1 commit into from Nov 24, 2020
Merged

Conversation

yaacov
Copy link
Member

@yaacov yaacov commented Nov 23, 2020

First pass on Metal3 plugin strings.

Missing from this PR - Actions, Forms, Dashboards

screenshot-localhost_9000-2020 11 23-14_01_09
screenshot-localhost_9000-2020 11 23-14_55_43
screenshot-localhost_9000-2020 11 23-14_56_12
screenshot-localhost_9000-2020 11 23-14_56_25
screenshot-localhost_9000-2020 11 23-14_56_41

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Nov 23, 2020
@openshift-ci-robot openshift-ci-robot added the component/metal3 Related to metal3-plugin label Nov 23, 2020
@yaacov
Copy link
Member Author

yaacov commented Nov 23, 2020

@rawagner please review

@yaacov
Copy link
Member Author

yaacov commented Nov 23, 2020

/retest

@rawagner
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 30743d8 into openshift:master Nov 24, 2020
@yaacov yaacov mentioned this pull request Nov 24, 2020
@spadgett spadgett added this to the v4.7 milestone Nov 30, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/metal3 Related to metal3-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants