Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSOLE-2494] Update Dockerfile.product for nodejs v14.15.0 #7304

Merged
merged 1 commit into from Nov 24, 2020

Conversation

yselkowitz
Copy link
Contributor

@yselkowitz yselkowitz commented Nov 23, 2020

@yselkowitz yselkowitz changed the title Update Dockerfile.product for nodejs v14.15.0 [CONSOLE-2494] Update Dockerfile.product for nodejs v14.15.0 Nov 23, 2020
@yselkowitz
Copy link
Contributor Author

/retest

@yselkowitz
Copy link
Contributor Author

/assign @bparees
/cc @zherman0

@bparees
Copy link

bparees commented Nov 24, 2020

/assign @spadgett
/unassign

@zherman0
Copy link
Member

Should we bump the yarn version as well once #7280 merges (updates yarn to 1.22.10). It would not need to be in this PR, we could open another one.

@yselkowitz
Copy link
Contributor Author

/retest

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, yselkowitz, zherman0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2020
@spadgett
Copy link
Member

Thank you @yselkowitz 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants