Bug 1900022: Search Page - Top Name/Label filter is not applied to selected Pipeline resources

[dtaylor113]

This PR fixes two issue with how the Pipeline plugin interacts with the console's search page:

1. Search page top Name/Label filter not being applied to Pipelines resource section
2. Pipeline resource section shows 2nd Name/Label filter.

Before

After

** Note: there is a remaining refresh bug using the Name filter & pipelines resource section/table. Follow Up Bug 1901207: Search Page - Pipeline resources table not immediately updated after Name filter applied or removed

[openshift-ci-robot]

@dtaylor113: This pull request references Bugzilla bug 1900022, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1900022: Search Page - Top labels field is not applied to selected Pipeline resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andrewballantyne]

Ah I see, this is a failure of passing forward params in our list pages. 🤔

Guess this has always been the case since the filters changes got added. Thanks @dtaylor113 ! I'll review this in more detail soon.

[openshift-ci-robot]

@dtaylor113: This pull request references Bugzilla bug 1900022, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1900022: Search Page - Top labels field is not applied to selected Pipeline resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dtaylor113]

Ah I see, this is a failure of passing forward params in our list pages.

Guess this has always been the case since the filters changes got added. Thanks @dtaylor113 ! I'll review this in more detail soon.

Hi @andrewballantyne, note there is still an issue in this area: Bug 1901207: Search Page - Pipeline resources table not immediately updated after Name filter applied or removed.
I'm not familiar enough with PipelineAugmentRuns[Wrapper] to attempt a fix. -thanks

[dtaylor113]

/retest

[christianvogt]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, dtaylor113

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@dtaylor113: All pull requests linked via external trackers have merged:

• openshift/console#7318

Bugzilla bug 1900022 has been moved to the MODIFIED state.

In response to this:

Bug 1900022: Search Page - Top Name/Label filter is not applied to selected Pipeline resources

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.