Removing Protractor annotations test from e2e, crud, and all test suites due to flakyness #7322
Conversation
| @@ -59,7 +59,6 @@ const testSuites = { | |||
| 'tests/crud.scenario.ts', | |||
| 'tests/secrets.scenario.ts', | |||
| 'tests/filter.scenario.ts', | |||
| 'tests/modal-annotations.scenario.ts', | |||
There was a problem hiding this comment.
We should leave the scenario and use xdescribe so we see they're disabled in the log and JUnit report.
There was a problem hiding this comment.
The downside to that is beforeAll and afterAll will still run...
There was a problem hiding this comment.
The downside to that is
beforeAllandafterAllwill still run...
i should say, base.scenario.ts including Create a test namespace will still run.
There was a problem hiding this comment.
I think that only runs once for the entire e2e suite?
There was a problem hiding this comment.
it runs for each suite. but it's fine. dave's gonna remove these soon anyhow.
There was a problem hiding this comment.
yes, and I just checked a few annotation failures, they seem to happen during the actual test, not in before hooks:
26) Modal Annotations
✔ Delete Annotation
✔ Add numeric Annotation from grid
✔ Add alphanumeric Annotation from object detail
✔ Add Annotation without value
✖ Add annotation wihout key (1 failure)
• Update Annotation from value to empty value: CONSOLE-394
• Update Annotation from empty value to value
• Cancel add Annotation
dtaylor113
force-pushed
the
protractor-disable-annotations-tests
branch
from
a1c09a1
to
3f64b91
Compare
dtaylor113
force-pushed
the
protractor-disable-annotations-tests
branch
from
3f64b91
to
811433d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
We are currently porting over annotation tests to Cypress: https://issues.redhat.com/browse/CONSOLE-2478