Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize the Bare Metal Hosts side nav name #7336

Conversation

pcbailey
Copy link
Contributor

This PR localizes the "Bare Metal Hosts" side navigation tab name.

Screenshot:
Selection_689

@openshift-ci-robot openshift-ci-robot added the component/metal3 Related to metal3-plugin label Nov 26, 2020
@pcbailey
Copy link
Contributor Author

@rawagner @yaacov Please review.

@christianvogt
Copy link
Contributor

Same comment as #7335 (comment)

@christianvogt
Copy link
Contributor

see #7341

@pcbailey pcbailey force-pushed the localize-bare-metal-hosts-nav-name branch from 23509bb to 1811e23 Compare December 2, 2020 15:22
@pcbailey
Copy link
Contributor Author

pcbailey commented Dec 2, 2020

@christianvogt Thanks for the heads up. I have updated this PR to use the %...% pattern.

@rawagner
Copy link
Contributor

rawagner commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
@yaacov
Copy link
Member

yaacov commented Dec 3, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 203c628 into openshift:master Dec 3, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@pcbailey pcbailey deleted the localize-bare-metal-hosts-nav-name branch October 26, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/metal3 Related to metal3-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants