add Kamelets- schema generated forms & yaml/form switching #7344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
component/knative
|
/cc @invincibleJai |
| <EventSourceSection | ||
| namespace={namespace} | ||
| kameletSource={kameletSource} | ||
| catalogFlow |
There was a problem hiding this comment.
we may not need to pass catalogFlow , as there will be just one flow now. I'll work on it to get this cleaned across
| @@ -167,6 +177,7 @@ export const EventSource: React.FC<Props> = ({ | |||
| namespace={namespace} | |||
| eventSourceStatus={eventSourceStatus} | |||
| eventSourceMetaDescription={eventSourceMetaDescription} | |||
| kameletSource={kameletSource} | |||
There was a problem hiding this comment.
do we need to pass as prop or shall we set formSchema in initial values if it's kamelet
There was a problem hiding this comment.
We need this. We can not set it in the initial value as it has been not used in the form.
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
Outdated
Show resolved
Hide resolved
4 tasks
vikram-raj
commented
Dec 1, 2020
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Show resolved
Hide resolved
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/utils/create-eventsources-utils.ts
Outdated
Show resolved
Hide resolved
vikram-raj
force-pushed
the
odc-5063
branch
3 times, most recently
from
0521f51
to
27011dd
Compare
|
/lgtm Verified all 6 kamelets[0] , works as expected |
frontend/packages/knative-plugin/src/components/add/EventSourcePage.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/EventSourceForm.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/knative-plugin/src/components/add/event-sources/EventSourceSection.tsx
Outdated
Show resolved
Hide resolved
|
/lgtm verified the changes !! |
|
/assign @rohitkrai03 |
rohitkrai03
suggested changes
Dec 2, 2020
frontend/packages/console-shared/src/components/formik-fields/DynamicFormField.tsx
Outdated
Show resolved
Hide resolved
|
/test analyze |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai, rohitkrai03, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
https://issues.redhat.com/browse/ODC-5063
Description:
when creating an source for kamelets, I should be presented with a form/yaml view and ability to switch between two
Screen shots / Gifs for design review:
Test setup: