guest agent test: alert when delete vm while user is logged in #7355
Conversation
|
Hi @omril-redhat. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest |
1 similar comment
|
/retest |
|
/retest
…On Mon, Nov 30, 2020, 6:33 PM OpenShift Merge Robot < ***@***.***> wrote:
@omril-redhat <https://github.com/omril-redhat>: The following test
*failed*, say /retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 1977e5a
<1977e5a>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_console/7355/pull-ci-openshift-console-master-e2e-gcp-console/1333442559065722880> /test
e2e-gcp-console
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift&repo=console&pr=7355>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:omril-redhat>
.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7355 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQR5VZSMV7TKJLJQG3LLQW3SSPCMRANCNFSM4UHL6YCQ>
.
|
|
@omril-redhat: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
openshift-ci-robot
added
the
ok-to-test
|
/retest |
openshift-ci-robot
removed
the
needs-ok-to-test
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
|
||
| it('ID(CNV-5472) Warn user when deleting a VM which has a logged in user ', async () => { | ||
| await vmLinux.navigateToDetail(); | ||
| await vmActions(VM_ACTION.Delete, false); |
There was a problem hiding this comment.
Can we use vmLinux.delete here?
There was a problem hiding this comment.
no, because we don't want to delete, just verify there is an alert
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gouyang, omril-redhat, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
No description provided.