Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n ocs dashboards #7368

Merged
merged 1 commit into from Dec 2, 2020
Merged

i18n ocs dashboards #7368

merged 1 commit into from Dec 2, 2020

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented Dec 1, 2020 •
edited

  • independent mode dashboard
  • internal mode dashboard
  • object service dashboard

Additional modifications:

  • dropdown options format on all ocs dashboards:
{
name: /*the string to be displayed and used for i18n*/
 id: /*a unique name of the option-key*/
}
  • unit test adjustments
  • i18n of empty states in core components of details-card,status-card,inventory-card,graph-empty

Namespaces added: ceph-storage-plugin, noobaa-storage-pugin

cc @rawagner @bipuladh @cloudbehl @a2batic

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dashboard Related to dashboard component/noobaa Related to noobaa-storage-plugin component/shared Related to console-shared labels Dec 1, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 1, 2020 •
edited

@rawagner changes for review graph-empty inventory dashboard.ts details-item monitoring

Thanks!

rawagner
rawagner suggested changes Dec 1, 2020
View reviewed changes
frontend/packages/console-shared/src/components/dashboard/status-card/states.tsx Outdated
@@ -29,7 +30,7 @@ export const healthStateMapping: { [key in HealthState]: HealthStateMappingValue
priority: 1,
health: HealthState.UNKNOWN,
icon: <GrayUnknownIcon title="Unknown" />,
message: 'Unknown',
message: i18next.t('dashboard~Unknown'),
Copy link
Contributor

@rawagner rawagner Dec 1, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add i18n for all states ?
I think we should convert healthStateMapping to function and pass t as param to make sure we get the correct translation when user changes the language

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds fair! We can change this map -> function
This will need some adjustments at other places therefore I would raise another PR for ease in handling.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this chnage from this PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And Created another PR #7372

@afreen23
Copy link
Contributor Author

afreen23 commented Dec 1, 2020

/hold
Fixing tests

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 1, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 1, 2020
@afreen23 afreen23 mentioned this pull request Dec 1, 2020
Merged
@afreen23 afreen23 force-pushed the i18n-ocs-dashboard branch 3 times, most recently from d589d29 to 12412e8 Compare December 1, 2020 12:38
@openshift-ci-robot openshift-ci-robot added the component/sdk Related to console-plugin-sdk label Dec 1, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 1, 2020

/test e2e-gcp-console

@rawagner
Copy link
Contributor

rawagner commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 1, 2020

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@cloudbehl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

i18n ocs dashboards
538c538 
 - independent mode dashboard
 - internal mode dashboard
 - object service dashboard

Additional modifications:
- dropdown options format to be {name: /*the string to be displayed and used for i18n*/,id: /*a unique name of the option-key*/} on all ocs dashboards
- unit test adjustments
- i18n of empty states in core components of details-card,inventory-card,graph-empty

Namespaces added: ceph-storage-plugin, noobaa-storage-pugin

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@a2batic
Copy link
Contributor

a2batic commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, afreen23, cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4388293 into openshift:master Dec 2, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner requested changes

@bipuladh bipuladh Awaiting requested review from bipuladh

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@rawagner rawagner

@cloudbehl cloudbehl

@a2batic a2batic

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/dashboard Related to dashboard component/noobaa Related to noobaa-storage-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@afreen23 @rawagner @openshift-bot @cloudbehl @a2batic @openshift-ci-robot @spadgett @openshift-merge-robot