Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart list should not return helm charts if the repo is disabled. #7369

Merged
merged 1 commit into from Dec 3, 2020
Merged

Helm chart list should not return helm charts if the repo is disabled. #7369

merged 1 commit into from Dec 3, 2020

Conversation

akashshinde
Copy link
Contributor

@akashshinde akashshinde commented Dec 1, 2020 •
edited

This PR adds supports to return helm chart listing of only enabled repositories.

@openshift-ci-robot openshift-ci-robot added the component/backend Related to backend label Dec 1, 2020
@akashshinde akashshinde changed the title Helm chart list should not return helm charts if the repo is disabled. [WIP] Helm chart list should not return helm charts if the repo is disabled. Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 1, 2020
pedjak
pedjak suggested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove WIP from PR title

pkg/helm/chartproxy/repos.go Show resolved Hide resolved
pkg/helm/chartproxy/repos.go Outdated Show resolved Hide resolved
pkg/helm/chartproxy/repos_test.go Outdated Show resolved Hide resolved
pkg/helm/chartproxy/repos_test.go Outdated Show resolved Hide resolved
pkg/helm/chartproxy/repos_test.go Outdated Show resolved Hide resolved
@akashshinde akashshinde changed the title [WIP] Helm chart list should not return helm charts if the repo is disabled. Helm chart list should not return helm charts if the repo is disabled. Dec 2, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2020
@akashshinde
Copy link
Contributor Author

/retest

pedjak
pedjak approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash

@pedjak
Copy link
Contributor

pedjak commented Dec 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 2, 2020
@akashshinde
Copy link
Contributor Author

/retest

@pedjak
Copy link
Contributor

pedjak commented Dec 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

rohitkrai03
rohitkrai03 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified UI with the changes. Works as expected.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akashshinde, pedjak, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 3c682a5 into openshift:master Dec 3, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedjak pedjak pedjak approved these changes

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@sbose78 sbose78 Awaiting requested review from sbose78

Assignees

@pedjak pedjak

@rohitkrai03 rohitkrai03

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@akashshinde @pedjak @openshift-bot @openshift-ci-robot @rohitkrai03 @spadgett @openshift-merge-robot