Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1901395: Remove edit template link #7370

Merged
merged 2 commits into from Dec 1, 2020
Merged

Bug 1901395: Remove edit template link #7370

merged 2 commits into from Dec 1, 2020

Conversation

metalice
Copy link
Contributor

@metalice metalice commented Dec 1, 2020 •
edited

Signed-off-by: Matan Schatzman matanschatzman@gmail.com

Fixes:
https://bugzilla.redhat.com/show_bug.cgi?id=1901395

Analysis / Root cause:
As agreed on https://bugzilla.redhat.com/show_bug.cgi?id=1901395

Solution Description:
Remove links to edit template

@metalice
Change link to default details page instead of yaml tab
70cc7b1 
Signed-off-by: Matan Schatzman <matanschatzman@gmail.com>
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Bugzilla bug 1901395, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1901395: Change link to default details page instead of yaml tab

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added the component/kubevirt Related to kubevirt-plugin label Dec 1, 2020
@metalice
Copy link
Contributor Author

metalice commented Dec 1, 2020

@rawagner @yaacov please review :)

@yaacov
Copy link
Member

yaacov commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2020
@metalice
Copy link
Contributor Author

metalice commented Dec 1, 2020

/lgtm cancel

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@metalice
Removed the edit template button
394ae08 
Signed-off-by: Matan Schatzman <matanschatzman@gmail.com>
@metalice metalice changed the title Bug 1901395: Change link to default details page instead of yaml tab Bug 1901395: Remove edit template link Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

@metalice: This pull request references Bugzilla bug 1901395, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1901395: Remove edit template link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaacov
Copy link
Member

yaacov commented Dec 1, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@metalice
Copy link
Contributor Author

metalice commented Dec 1, 2020

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@metalice
Copy link
Contributor Author

metalice commented Dec 1, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 385590b into openshift:master Dec 1, 2020
@openshift-ci-robot
Copy link
Contributor

@metalice: All pull requests linked via external trackers have merged:

Bugzilla bug 1901395 has been moved to the MODIFIED state.

In response to this:

Bug 1901395: Remove edit template link

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glekner glekner Awaiting requested review from glekner

@gouyang gouyang Awaiting requested review from gouyang

Assignees

@yaacov yaacov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@metalice @openshift-ci-robot @yaacov @openshift-bot @spadgett @openshift-merge-robot