Gherkin display task runs associated with pipeline run odc 3712 #7377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gajanan-more
reviewed
Dec 2, 2020
sanketpathak
force-pushed
the
gherkin_display_TaskRuns_associated_with_PipelineRun_ODC-3712
branch
from
200cc9a
to
8248609
Compare
gajanan-more
suggested changes
Dec 2, 2020
...dev-console/integration-tests/features/pipelines/pipeline-Display_task_runs_ODC-3712.feature
Show resolved
Hide resolved
...dev-console/integration-tests/features/pipelines/pipeline-Display_task_runs_ODC-3712.feature
Outdated
Show resolved
Hide resolved
sanketpathak
force-pushed
the
gherkin_display_TaskRuns_associated_with_PipelineRun_ODC-3712
branch
from
8248609
to
73962f0
Compare
gajanan-more
approved these changes
Dec 2, 2020
|
/lgtm |
| When user clicks on pipeline runs tab | ||
| And user clicks on a pipeline run to see Task Runs tab | ||
| And user clicks on Task Runs tab | ||
| Then user can see different task runs based on number of tasks present in pipeline |
There was a problem hiding this comment.
Suggested change
| Then user can see different task runs based on number of tasks present in pipeline | |
| Then user can see different task runs based on number of tasks executed in pipeline |
| Given user has pipeline runs present | ||
| And user is on Pipeline Runs Details page | ||
| When user clicks on Task Runs tab | ||
| And user clicks on breadcrumb of a task run |
There was a problem hiding this comment.
Suggested change
| And user clicks on breadcrumb of a task run | |
| And user clicks on a kebab menu of a task run in the list |
| And user clicks on a task run | ||
| Then user is redirected to Task Run Details tab | ||
| And user can see "Details", "Log", "YAML" and "Events" tab | ||
| And user can see Status and Log snippet in "Details" tab |
There was a problem hiding this comment.
Break into two scenarios
- For a succeeded task run only
statusandpodfields are shown
- For a failed task run, following fields are shown
There was a problem hiding this comment.
Added two scenarios for passed and failed task runs
sanketpathak
force-pushed
the
gherkin_display_TaskRuns_associated_with_PipelineRun_ODC-3712
branch
from
73962f0
to
fe1fe26
Compare
|
/lgtm |
|
/assign @makambalaji |
makambalaji
reviewed
Dec 3, 2020
Comment on lines
12
to
13
| Given user is at pipeline details page | ||
| And pipeline runs are present |
There was a problem hiding this comment.
Suggested change
| Given user is at pipeline details page | |
| And pipeline runs are present | |
| Given user is at pipeline details page with pipeline Runs |
Comment on lines
23
to
24
| Given user has pipeline runs present | ||
| And user is on Pipeline Runs Details page |
There was a problem hiding this comment.
Suggested change
| Given user has pipeline runs present | |
| And user is on Pipeline Runs Details page | |
| Given user is at pipeline details page with pipeline runs |
| And user is on Pipeline Runs Details page | ||
| When user clicks on Task Runs tab | ||
| And user clicks on a kebab menu of a task run in the list | ||
| Then user can see "Edit labels", "Edit annotations", "Edit Task Run" and "Delete Task Run" |
There was a problem hiding this comment.
Suggested change
| Then user can see "Edit labels", "Edit annotations", "Edit Task Run" and "Delete Task Run" | |
| Then user can see kebab menu options Edit labels, Edit annotations, Edit Task Run and Delete Task Run |
Comment on lines
32
to
33
| Given user is at pipeline details page | ||
| And pipeline runs are present |
There was a problem hiding this comment.
Suggested change
| Given user is at pipeline details page | |
| And pipeline runs are present | |
| Given user is at pipeline details page with pipeline runs |
| Given user has pipeline runs present | ||
| And user is on Pipeline Runs Details page | ||
| When user clicks on Task Runs tab | ||
| And user clicks on a kebab menu of a task run in the list |
There was a problem hiding this comment.
Suggested change
| And user clicks on a kebab menu of a task run in the list | |
| And user clicks kebab menu of a task run |
Comment on lines
45
to
46
| Given user is at pipeline details page | ||
| And pipeline runs are present |
There was a problem hiding this comment.
Suggested change
| Given user is at pipeline details page | |
| And pipeline runs are present | |
| Given user is at pipeline details page with pipeline runs |
sanketpathak
force-pushed
the
gherkin_display_TaskRuns_associated_with_PipelineRun_ODC-3712
branch
from
fe1fe26
to
612b1c6
Compare
sanketpathak
force-pushed
the
gherkin_display_TaskRuns_associated_with_PipelineRun_ODC-3712
branch
from
612b1c6
to
5b860df
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gajanan-more, karthikjeeyar, makambalaji, sanketpathak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://issues.redhat.com/browse/ODC-3712
Story: https://issues.redhat.com/browse/ODC-4851