Bug 1897008: Cypress: reenable check for 'aria-hidden-focus' rule & checkA11y test for modals #7382
Conversation
|
@dtaylor113: This pull request references Bugzilla bug 1897008, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/severity-medium
|
@dtaylor113: This pull request references Bugzilla bug 1897008, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dtaylor113 Can we simply add |
Tried this and it didn't work :-( Neither did any of the suggestions here |
dtaylor113
force-pushed
the
cypress-a11y-aria-hidden-focus
branch
from
6163bec
to
3a5b471
Compare
|
@dtaylor113: This pull request references Bugzilla bug 1897008, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dtaylor113
force-pushed
the
cypress-a11y-aria-hidden-focus
branch
from
e0304a3
to
dc4f163
Compare
|
@dtaylor113: This pull request references Bugzilla bug 1897008, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Updated PR to re-enables the a11y check for 'aria-hidden-focus' rule and allows A11y testing of Modals in isolation. Updated modal div to |
|
/retest |
| ], | ||
| }); | ||
| a11yTestResults.numberChecks += 1; | ||
| cy.checkA11y( | ||
| null, | ||
| selector || null, |
There was a problem hiding this comment.
I don't think you need || null here? Does it cause a problem leaving that off?
There was a problem hiding this comment.
fixed, removed || null
dtaylor113
force-pushed
the
cypress-a11y-aria-hidden-focus
branch
from
dc4f163
to
40034f8
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtaylor113, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@dtaylor113: All pull requests linked via external trackers have merged: Bugzilla bug 1897008 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR re-enables the a11y check for 'aria-hidden-focus' rule and allows A11y testing of Modals in isolation. Updated modal div to
<div id="modal-container" role="dialog" aria-modal="true" />.