Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation on storage & nodes install step #7389

Merged
merged 1 commit into from Dec 3, 2020

Conversation

cloudbehl
Copy link
Contributor

Signed-off-by: Ankush Behl cloudbehl@gmail.com

@openshift-ci-robot openshift-ci-robot added component/ceph Related to ceph-storage-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2020
@afreen23
Copy link
Contributor

afreen23 commented Dec 2, 2020

@cloudbehl we need to do the change for internal mode as well.

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
@cloudbehl
Copy link
Contributor Author

@afreen23 updated for internal mode as well

@a2batic
Copy link
Contributor

a2batic commented Dec 3, 2020

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@a2batic
Copy link
Contributor

a2batic commented Dec 3, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@afreen23
Copy link
Contributor

afreen23 commented Dec 3, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2020
@cloudbehl
Copy link
Contributor Author

/test analyze

@openshift-merge-robot openshift-merge-robot merged commit f302424 into openshift:master Dec 3, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants