New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1901531: Fix runtime error in create CR form #7397
Conversation
In some cases, an uncaught exception could be thrown from dynamically generated array form fields. This was happening when a nested array field had an explicitly set 'null' value. This is a workaround that adds a fallback value to object and array fields to prevent this runtime error. An issue and fix have also been opened upstream in the react-jsonschema-form repo. rjsf-team/react-jsonschema-form#2153 rjsf-team/react-jsonschema-form#2154
@TheRealJon: This pull request references Bugzilla bug 1901531, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@TheRealJon: All pull requests linked via external trackers have merged: Bugzilla bug 1901531 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In some cases, an uncaught exception could be thrown from dynamically generated array form fields.
This was happening when a nested array field had an explicitly set 'null' value. This is a
workaround that adds a fallback value to object and array fields to prevent this runtime error. An
issue and fix have also been opened upstream in the react-jsonschema-form repo.
rjsf-team/react-jsonschema-form#2153
rjsf-team/react-jsonschema-form#2154