Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1866320: Changes to Capacity Metrics in OCS Persistent Storage Dashboard #7404

Merged
merged 1 commit into from Dec 3, 2020
Merged

Bug 1866320: Changes to Capacity Metrics in OCS Persistent Storage Dashboard #7404

merged 1 commit into from Dec 3, 2020

Conversation

bipuladh
Copy link
Contributor

@bipuladh bipuladh commented Dec 3, 2020

  • Add Raw Capacity Card in Dashboard
  • Remove Avaiable Metric from Breakdown Card
  • Rename Capacity Breakdown Card
  • Add Info Tip to Capacity Breakdown Card
    Screenshot:
    Screenshot from 2020-12-03 16-19-19
    Screenshot from 2020-12-03 14-14-10
    Screenshot from 2020-12-03 14-20-13

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 3, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2020
bipuladh
bipuladh commented Dec 3, 2020
View reviewed changes
frontend/packages/ceph-storage-plugin/src/constants/queries.ts
Comment on lines +76 to +80
export const CAPACITY_INFO_QUERIES = {
[StorageDashboardQuery.RAW_CAPACITY_TOTAL]: 'ceph_cluster_total_bytes',
[StorageDashboardQuery.RAW_CAPACITY_USED]: 'ceph_cluster_total_used_raw_bytes',
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anmolsachan PTAL

afreen23
afreen23 suggested changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Externalize the strings in following format:
ceph-storage-plugin~{string}

...c/components/dashboard-page/storage-dashboard/capacity-breakdown/capacity-breakdown-card.tsx Outdated Show resolved Hide resolved
...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
afreen23
afreen23 approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@afreen23 afreen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two comments, approved from my end

...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
...ugin/src/components/dashboard-page/storage-dashboard/raw-capacity-card/raw-capacity-card.tsx Outdated Show resolved Hide resolved
@cloudbehl
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@bipuladh
Changes to Capacity Metrics in OCS Persistent Storage Dashboard
40fcc35 
 - Add Raw Capacity Card in Dashboard
 - Remove Avaiable Metric from Breakdown Card
 - Rename Capacity Breakdown Card
 - Add Info Tip to Capacity Breakdown Card
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@afreen23
Copy link
Contributor

afreen23 commented Dec 3, 2020

/test analyze
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2020
@anmolsachan
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, anmolsachan, bipuladh, cloudbehl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 12f6d06 into openshift:master Dec 3, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@bipuladh bipuladh changed the title Changes to Capacity Metrics in OCS Persistent Storage Dashboard Bug 1866320: Changes to Capacity Metrics in OCS Persistent Storage Dashboard Dec 14, 2020
@openshift-ci-robot
Copy link
Contributor

@bipuladh: All pull requests linked via external trackers have merged:

Bugzilla bug 1866320 has been moved to the MODIFIED state.

In response to this:

Bug 1866320: Changes to Capacity Metrics in OCS Persistent Storage Dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afreen23 afreen23 afreen23 approved these changes

@a2batic a2batic Awaiting requested review from a2batic

Assignees

@cloudbehl cloudbehl

@anmolsachan anmolsachan

@afreen23 afreen23

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bipuladh @cloudbehl @afreen23 @anmolsachan @openshift-ci-robot @spadgett @openshift-merge-robot