Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n ocs day1 and day2 operations #7406

Merged
merged 1 commit into from Dec 4, 2020
Merged

i18n ocs day1 and day2 operations #7406

merged 1 commit into from Dec 4, 2020

Conversation

afreen23
Copy link
Contributor

@afreen23 afreen23 commented Dec 3, 2020 •
edited

  • create storage cluster
  • create backing store
  • create bucket class
  • add capacity
  • disk replacement
  • create new pool
  • edit bucket class
  • disk inventory page

Also i18n the lso plugin, since ocs is dependent on lso package

Signed-off-by: Afreen Rahman afrahman@redhat.com

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Dec 3, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/lso Related to local-storage-operator-plugin component/noobaa Related to noobaa-storage-plugin labels Dec 3, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 3, 2020 •
edited

console/core changes : lso ns addition webpack chnages

@afreen23 afreen23 changed the title i18n ocs day1 and day2 perations i18n ocs day1 and day2 operations Dec 3, 2020
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 3, 2020

/test backend

@afreen23
Copy link
Contributor Author

afreen23 commented Dec 3, 2020

/test /e2e-gcp-console

@openshift-ci-robot
Copy link
Contributor

@afreen23: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test analyze
  • /test backend
  • /test e2e-gcp-console
  • /test frontend
  • /test images
  • /test kubevirt-plugin

Use /test all to run the following jobs:

  • pull-ci-openshift-console-master-analyze
  • pull-ci-openshift-console-master-backend
  • pull-ci-openshift-console-master-e2e-gcp-console
  • pull-ci-openshift-console-master-frontend
  • pull-ci-openshift-console-master-images

In response to this:

/test /e2e-gcp-console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Contributor Author

afreen23 commented Dec 3, 2020

/test e2e-gcp-console

rawagner
rawagner reviewed Dec 3, 2020
View reviewed changes
...ge-plugin/src/components/attached-devices-mode/lso-disk-inventory/disk-replacement-modal.tsx Outdated Show resolved Hide resolved
...storage-plugin/src/components/attached-devices-mode/lso-disk-inventory/ocs-status-column.tsx Outdated Show resolved Hide resolved
...packages/ceph-storage-plugin/src/components/modals/add-capacity-modal/add-capacity-modal.tsx Outdated Show resolved Hide resolved
...ages/ceph-storage-plugin/src/components/ocs-install/attached-devices/create-sc/create-sc.tsx
title={
!hasNoProvSC
? t('ceph-storage-plugin~Missing storage class')
: 'Internal - Attached devices'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing t

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are suggested by marketing team to not i18n this the ocs modes - Internal/Internal-Attached devices/External.
Hence keeping it in plain english

@afreen23 afreen23 force-pushed the i18n-ocs-day1and2 branch 2 times, most recently from f9f000f to 7ae7736 Compare December 3, 2020 17:12
Signed-off-by: Afreen Rahman <afrahman@redhat.com>
ce61e8a 
i18n ocs day1 and day2 operations

- create storage cluster
- create backing store
- create bucket class
- add capacity
- disk replacement
- create new pool
- edit bucket class
- disk inventory page
- create OB/OBC
- details page of OB/OBC

Also i18n the lso plugin, since ocs is dependent on lso package

Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@afreen23
Copy link
Contributor Author

afreen23 commented Dec 4, 2020

/test backend

@rawagner
Copy link
Contributor

rawagner commented Dec 4, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afreen23, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 4, 2020
@openshift-merge-robot openshift-merge-robot merged commit c7bb37c into openshift:master Dec 4, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawagner rawagner rawagner left review comments

@a2batic a2batic Awaiting requested review from a2batic

@cloudbehl cloudbehl Awaiting requested review from cloudbehl

Assignees

@rawagner rawagner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin component/core Related to console core functionality component/lso Related to local-storage-operator-plugin component/noobaa Related to noobaa-storage-plugin kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@afreen23 @openshift-ci-robot @rawagner @spadgett @openshift-merge-robot