Add feature guard for Multus #7419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bipuladh
commented
Dec 4, 2020
bipuladh
commented
openshift-ci-robot
added
the
approved
bipuladh
force-pushed
the
feature_gurads
branch
from
e30ae8f
to
ef22871
Compare
afreen23
suggested changes
Dec 7, 2020
frontend/packages/ceph-storage-plugin/src/components/ocs-install/attached-devices/install.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/review-and-create-step.tsx
Outdated
Show resolved
Hide resolved
frontend/packages/ceph-storage-plugin/src/components/ocs-install/types.ts
Outdated
Show resolved
Hide resolved
...end/packages/ceph-storage-plugin/src/components/ocs-install/internal-mode/install-wizard.tsx
Outdated
Show resolved
Hide resolved
|
/retest |
bipuladh
force-pushed
the
feature_gurads
branch
from
ef22871
to
724a9a9
Compare
|
/retest |
afreen23
suggested changes
Dec 8, 2020
frontend/packages/ceph-storage-plugin/src/components/ocs-install/install-page.tsx
Outdated
Show resolved
Hide resolved
...plugin/src/components/ocs-install/attached-devices/create-sc/wizard-pages/configure-step.tsx
Outdated
Show resolved
Hide resolved
...plugin/src/components/ocs-install/attached-devices/create-sc/wizard-pages/configure-step.tsx
Outdated
Show resolved
Hide resolved
...rc/components/ocs-install/attached-devices/create-sc/wizard-pages/review-and-create-step.tsx
Outdated
Show resolved
Hide resolved
bipuladh
force-pushed
the
feature_gurads
branch
from
724a9a9
to
4c279c9
Compare
cloudbehl
reviewed
Dec 8, 2020
...e-plugin/src/components/ocs-install/internal-mode/install-wizard-steps/review-and-create.tsx
Outdated
Show resolved
Hide resolved
bipuladh
force-pushed
the
feature_gurads
branch
from
4c279c9
to
72f8efc
Compare
bipuladh
force-pushed
the
feature_gurads
branch
from
72f8efc
to
fa1a9d0
Compare
bipuladh
commented
Dec 9, 2020
| }) | ||
| .catch(() => setClusterServiceVersion(null)); | ||
| }, [appName, ns]); | ||
| const [infra, infraLoaded, infraError] = useK8sGet<any>(InfrastructureModel, 'cluster'); |
There was a problem hiding this comment.
any since we don't have a type definition for InrastructureModel.
afreen23
suggested changes
Dec 9, 2020
| }) | ||
| .catch(() => setClusterServiceVersion(null)); | ||
| }, [appName, ns]); | ||
| const [infra, infraLoaded, infraError] = useK8sGet<any>(InfrastructureModel, 'cluster'); |
There was a problem hiding this comment.
nit: place the use- hooks at one place
| EXTERNAL: 'EXTERNAL', | ||
| MINIMAL_DEPLOYMENT: 'MINIMAL_DEPLOYMENT', | ||
| ENCRYPTION: 'ENCRYPTION', | ||
| MULTUS: 'MULTUS', |
There was a problem hiding this comment.
Can we name the flags something like OCS-MULTUS ? Just to differentiate with rest of the console flags.
bipuladh
force-pushed
the
feature_gurads
branch
2 times, most recently
from
03c023a
to
9b5a61c
Compare
afreen23
suggested changes
Dec 9, 2020
Comment on lines
47
to
50
| const csvResource = useDeepCompareMemoize<WatchK8sResource>( | ||
| { | ||
| kind: referenceForModel(ClusterServiceVersionModel), | ||
| name: appName, | ||
| namespace: ns, | ||
| isList: false, | ||
| }, | ||
| true, | ||
| ); | ||
|
|
There was a problem hiding this comment.
useK8sWatchResource already uses useDeepCompareMemoize.
Suggested change
| const csvResource = useDeepCompareMemoize<WatchK8sResource>( | |
| { | |
| kind: referenceForModel(ClusterServiceVersionModel), | |
| name: appName, | |
| namespace: ns, | |
| isList: false, | |
| }, | |
| true, | |
| ); | |
| const csvResource = | |
| { | |
| kind: referenceForModel(ClusterServiceVersionModel), | |
| name: appName, | |
| namespace: ns, | |
| isList: false, | |
| }; | |
Refactor loading of CSV and Infrastruture in Install Page
bipuladh
force-pushed
the
feature_gurads
branch
from
9b5a61c
to
49b36a4
Compare
afreen23
approved these changes
Dec 9, 2020
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a2batic, afreen23, bipuladh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.