Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert last used namespace local storage to userSettings #7433

Merged
merged 1 commit into from Dec 8, 2020
Merged

convert last used namespace local storage to userSettings #7433

merged 1 commit into from Dec 8, 2020

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Dec 5, 2020 •
edited

fixes: https://issues.redhat.com/browse/ODC-5111

This PR move the bridge/last-namespace-name local storage to the user settings.
No UI changes.
Raising this PR since CI is stuck on the old PR #7411.

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Dec 5, 2020
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Dec 5, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2020
@invincibleJai
Copy link
Member

/assign @rohitkrai03

rohitkrai03
rohitkrai03 approved these changes Dec 5, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2020
@sahil143
Copy link
Contributor Author

sahil143 commented Dec 5, 2020

/retest

2 similar comments
@sahil143
Copy link
Contributor Author

sahil143 commented Dec 6, 2020

/retest

@invincibleJai
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@invincibleJai
Copy link
Member

/test analyze

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@invincibleJai
Copy link
Member

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@dtaylor113
Copy link
Contributor

/test all

spadgett
spadgett reviewed Dec 7, 2020
View reviewed changes
frontend/public/locales/en/public.json Outdated
@@ -7,6 +7,7 @@
"Confirm": "Confirm",
"{{description}} for": "{{description}} for",
"Edit": "Edit",
"{{dateFromNow}}": "{{dateFromNow}}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't ever have a translation key that is only a parameter. It doesn't make sense. Can you revert this change?

I think we need to disable the i18n test on timestamp. We don't expect the moment.js relative times to be psuedolocalized since they're not using i18next.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR to disable i18n test for timestamps: #7445

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2020
@invincibleJai
Copy link
Member

/retest

@invincibleJai
Copy link
Member

/test all

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@invincibleJai
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 0a0880c into openshift:master Dec 8, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 9, 2020
@jerolimov jerolimov mentioned this pull request Dec 10, 2020
Merged
4 tasks
@dtaylor113 dtaylor113 mentioned this pull request Jan 5, 2021
Merged
@rohitkrai03 rohitkrai03 mentioned this pull request May 21, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@nemesis09 nemesis09 Awaiting requested review from nemesis09

Assignees

@invincibleJai invincibleJai

@rohitkrai03 rohitkrai03

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sahil143 @invincibleJai @openshift-bot @dtaylor113 @openshift-ci-robot @spadgett @rohitkrai03 @openshift-merge-robot