Fix pipelinerun visualization inprogress crash

[karthikjeeyar]

Fixes:

https://issues.redhat.com/browse/ODC-5160

Analysis / Root cause:
When starting a Pipeline multiple times the console crashes sometimes with this JavaScript error

Solution Description:
If pipeline run is in progress and doesn't have enough information(pipelineSpec) to form the pipeline, then do not render the visualization graph.

Screen shots / Gifs for design review:

Unit test coverage report:

Test setup:

1. Install Openshift pipelines operator
2. Create a pipeline using a add flow or yaml
3. Start the pipeline run multiple times using start last run option.

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

/kind bug
/assign @jerolimov

[karthikjeeyar]

/test analyze

[jerolimov]

Crash is solved. 👍

The update is visible to the user, so that visualization comes after the data is available.

/lgtm
/assign @andrewballantyne

[andrewballantyne]

I think we actually want the solution to be in frontend/packages/pipelines-plugin/src/components/pipelineruns/detail-page-tabs/PipelineRunVisualization.tsx... this is a problem with our pulling the Pipeline logic from the Pipeline Run... which is a matter of time.

Making the change in frontend/packages/pipelines-plugin/src/components/pipelines/detail-page-tabs/pipeline-details/PipelineVisualization.tsx sets us up for an awkward situation of allowing the creation of a PipelineVisualization without a Pipeline -- and that's not ideal.

The solution should also be a Loading indicator not a null as when I reproduce this scenario and get a null back from the Pipeline it removes the graph and then pops back in without warning. Probably a better use experience to spin.

[andrewballantyne]

Crash is solved. 👍

Definitely solved the crash... so this is an okay solution to the problem, however...

The update is visible to the user, so that visualization comes after the data is available.

This is probably not the best user experiernce.

/lgtm cancel

[karthikjeeyar]

Moved the check to pipelineRunVisualization.tsx and added loader for better UX.

[andrewballantyne]

cc @bgliwa01

[bgliwa01]

lgtm!

[andrewballantyne]

/lgtm

Slight improvement on the solution @jerolimov lgtm'ed -- we talked about this solution and he was in agreement. Let's get this merged 😄

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, bgliwa01, jerolimov, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/pipelines-plugin/OWNERS [andrewballantyne]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment