Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2381: Support dynamic demo plugin deployment on cluster #7471

Merged
merged 1 commit into from Dec 23, 2020
Merged

CONSOLE-2381: Support dynamic demo plugin deployment on cluster #7471

merged 1 commit into from Dec 23, 2020

Conversation

vojtechszocs
Copy link
Contributor

@vojtechszocs vojtechszocs commented Dec 8, 2020 •
edited

  • Add Dockerfile to build the demo plugin image.
  • Add Kubernetes manifest to deploy demo plugin on the cluster.
  • Add basic README for the demo plugin.

The image is based on official Node.js image, using http-server.sh script as the entry point and running as node user.

@spadgett Built image size is 985MB, is this OK or should we consider using node:alpine as the base image to reduce its size?

$ docker image ls -f "reference=node:10" -f "reference=test"
REPOSITORY   TAG       IMAGE ID       CREATED        SIZE
test         latest    855fa54f99c3   24 hours ago   985MB
node         10        78e6fbf9befd   6 days ago     911MB

When building the Docker image, we need the whole Console repo as the build context. This is because frontend/codegen.yml is referencing GraphQL schemas at pkg/graphql.

The plugin HTTP server runs at port 9001 with caching disabled and CORS enabled.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2020
@vojtechszocs vojtechszocs changed the title Support dynamic demo plugin deployment on cluster CONSOLE-2381: Support dynamic demo plugin deployment on cluster Dec 8, 2020
@vojtechszocs
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 8, 2020
@openshift-ci-robot openshift-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@vojtechszocs vojtechszocs force-pushed the dynamic-demo-plugin-deploy branch 2 times, most recently from a2d286e to 3dc8bcb Compare December 18, 2020 19:28
@vojtechszocs
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2020
@vojtechszocs
Copy link
Contributor Author

/retest

jhadvig
jhadvig requested changes Dec 21, 2020
View reviewed changes
Dockerfile.plugins.demo Outdated Show resolved Hide resolved
frontend/dynamic-demo-plugin/README.md Outdated Show resolved Hide resolved
frontend/dynamic-demo-plugin/k8s-manifest.yaml Outdated Show resolved Hide resolved
frontend/dynamic-demo-plugin/README.md Outdated Show resolved Hide resolved
frontend/dynamic-demo-plugin/README.md Outdated Show resolved Hide resolved
@vojtechszocs
Copy link
Contributor Author

@jhadvig Thanks for the review! PR updated, please have a second look.

jhadvig
jhadvig approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vojtechszocs lets suqsh this into a single commit and we can tag it 👍
/approve

@jhadvig
Copy link
Member

jhadvig commented Dec 22, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2020
@jhadvig
Copy link
Member

jhadvig commented Dec 22, 2020

/approve

rhamilto
rhamilto approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 19ba967 into openshift:master Dec 23, 2020
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamilto rhamilto rhamilto approved these changes

@jhadvig jhadvig jhadvig approved these changes

@kyoto kyoto Awaiting requested review from kyoto

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vojtechszocs @jhadvig @openshift-ci-robot @openshift-bot @rhamilto @spadgett @openshift-merge-robot