Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1905696: i18n ClusterMoreUpdatesModal #7473

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Bug 1905696: i18n ClusterMoreUpdatesModal #7473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 6 additions & 4 deletions frontend/public/components/modals/cluster-more-updates-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import * as React from 'react';
import { useTranslation } from 'react-i18next';
import { ActionGroup, Button } from '@patternfly/react-core';

import {
Expand All @@ -20,16 +21,17 @@ export const ClusterMoreUpdatesModal: React.FC<ClusterMoreUpdatesModalProps> = (
const availableUpdates = getSortedUpdates(cv);
const moreAvailableUpdates = availableUpdates.slice(1).reverse();
const releaseNotes = showReleaseNotes();
const { t } = useTranslation();

return (
<div className="modal-content">
<ModalTitle>Other Available Paths</ModalTitle>
<ModalTitle>{t('modal~Other available paths')}</ModalTitle>
<ModalBody>
<table className="table">
<thead>
<tr>
<th>Version</th>
{releaseNotes && <th>Release Notes</th>}
<th>{t('modal~Version')}</th>
{releaseNotes && <th>{t('modal~Release notes')}</th>}
</tr>
</thead>
<tbody>
Expand All @@ -55,7 +57,7 @@ export const ClusterMoreUpdatesModal: React.FC<ClusterMoreUpdatesModalProps> = (
<ModalFooter inProgress={false}>
<ActionGroup className="pf-c-form pf-c-form__actions--right pf-c-form__group--no-top-margin">
<Button type="button" variant="primary" onClick={cancel}>
Close
{t('Close')}
</Button>
</ActionGroup>
</ModalFooter>
Expand Down
3 changes: 3 additions & 0 deletions frontend/public/locales/en/modal.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"Cluster ID": "Cluster ID",
"API server": "API server",
"OpenShift is Red Hat's container application platform that allows developers to quickly develop, host, and scale applications in a cloud environment.": "OpenShift is Red Hat's container application platform that allows developers to quickly develop, host, and scale applications in a cloud environment.",
"Other available paths": "Other available paths",
"Version": "Version",
"Release notes": "Release notes",
"Manage columns": "Manage columns",
"Selected columns will appear in the table.": "Selected columns will appear in the table.",
"You can select up to {{MAX_VIEW_COLS}} columns": "You can select up to {{MAX_VIEW_COLS}} columns",
Expand Down
1 change: 1 addition & 0 deletions frontend/public/locales/en/public.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"Update": "Update",
"Create": "Create",
"Save": "Save",
"Close": "Close",
"Confirm": "Confirm",
"{{description}} for": "{{description}} for",
"Edit": "Edit",
Expand Down