Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2467: i18n localization for project dashboard #7474

Merged
merged 1 commit into from Dec 21, 2020
Merged

CONSOLE-2467: i18n localization for project dashboard #7474

merged 1 commit into from Dec 21, 2020

Conversation

jcaianirh
Copy link
Member

Addresses: https://issues.redhat.com/browse/CONSOLE-2467

Externalize strings for project dashboards.

@openshift-ci-robot openshift-ci-robot added component/dashboard Related to dashboard component/shared Related to console-shared labels Dec 8, 2020
spadgett
spadgett approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for approvals
/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Dec 9, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaianirh, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Dec 10, 2020
@yapei
Copy link
Contributor

yapei commented Dec 11, 2020

tested locally and no issues found

@yapei
Copy link
Contributor

yapei commented Dec 11, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Dec 11, 2020
@sferich888
Copy link

/label px-approved
/unassign @sferich888

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Dec 17, 2020
@jcaianirh
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@jcaianirh jcaianirh mentioned this pull request Dec 17, 2020
Closed
@pweil- pweil- added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 21, 2020
@pweil-
Copy link
Contributor

pweil- commented Dec 21, 2020

manually adding valid-bug until we work out openshift/release#14440 since the console team is piloting the no feature freeze effort and this PR has all acks, approvals, and lgtms

@jcaianirh jcaianirh mentioned this pull request Dec 21, 2020
Merged
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 45f0e68 into openshift:master Dec 21, 2020
@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/core Related to console core functionality component/dashboard Related to dashboard component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@jcaianirh @openshift-ci-robot @ahardin-rh @yapei @sferich888 @pweil- @openshift-bot @spadgett @openshift-merge-robot