New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906684: handles application group issue with EventSource creation #7481
Bug 1906684: handles application group issue with EventSource creation #7481
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invincibleJai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind bug |
}), | ||
...(!appGroupName && { | ||
name: '', | ||
selectedKey: '#UNASSIGNED_APP#', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use const UNASSIGNED_APPLICATIONS_KEY
here?
@vikram-raj we can get this fixed as separate PR/ticket as this is not related to current issue being fixed (can add accesReview even before i.e don't show Kamelet source in catalog if user don't have create access for KB, WDYT? |
d2fd50d
to
ab08db3
Compare
Agree, we can handle it in a separate issue. And can we hide the Event Source card from the add page if the user has only view access to the namespace? |
@invincibleJai: This pull request references Bugzilla bug 1906684, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified it. Works as expected.
/lgtm
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@invincibleJai: All pull requests linked via external trackers have merged: Bugzilla bug 1906684 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5239
Analysis / Root cause:
Event Source creation fails if user selects no app group and switch to yaml and then to form as application name had text "no application group" as part of annotations
Solution Description:
handles application group issue with EventSource creation
Unit test coverage report:
Browser conformance: