Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1905977: Gherkin script pipeline metrics odc 3711 #7482

Merged
merged 2 commits into from Dec 11, 2020
Merged

Bug 1905977: Gherkin script pipeline metrics odc 3711 #7482

merged 2 commits into from Dec 11, 2020

Conversation

sanketpathak
Copy link
Contributor

@sanketpathak sanketpathak commented Dec 9, 2020 •
edited

@openshift-ci-robot openshift-ci-robot added the component/dev-console Related to dev-console label Dec 9, 2020
@sanketpathak sanketpathak changed the title Gherkin script pipeline metrics odc 3711 Bug 1905977: Gherkin script pipeline metrics odc 3711 Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 9, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: This pull request references Bugzilla bug 1905977, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1905977: Gherkin script pipeline metrics odc 3711

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar
karthikjeeyar reviewed Dec 9, 2020
View reviewed changes
.../packages/dev-console/integration-tests/features/pipelines/pipeline_metrics_ODC-3711.feature Outdated
Scenario: Graphs in dashboard tab
Given user is in pipeline details tab
And pipeline run is present
When user clicks on dashboard tab
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title dashboard is likely to be changed, not confirmed yet. will you create a follow up PR to change it??

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure I'll create a gherkin task for it. Is there a bug/task created for this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not yet, but will notify you once it is created.

.../packages/dev-console/integration-tests/features/pipelines/pipeline_metrics_ODC-3711.feature Outdated
Given user is in pipeline details tab
And pipeline run is present
When user clicks on dashboard tab
Then user can see Time Range and Refresh Interval fields with value as 1 day and 30 seconds respectively
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Then user can see Time Range and Refresh Interval fields with value as 1 day and 30 seconds respectively
Then user can see Time Range and Refresh Interval dropdowns with a default value of 1 day and 30 seconds respectively

.../packages/dev-console/integration-tests/features/pipelines/pipeline_metrics_ODC-3711.feature Outdated
Given user is in pipeline details tab
And pipeline run has just started
When user clicks on dashboard tab
Then user can see Time Range and Refresh Interval fields with value as 1 day and 30 seconds respectively
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change it based on my previous comment

@sanketpathak sanketpathak force-pushed the gherkin_script_pipeline_metrics_ODC-3711 branch from dc6ffbf to abfa1d0 Compare December 9, 2020 15:33
@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
gajanan-more
gajanan-more suggested changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@gajanan-more gajanan-more left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the indentation of script.

@sanketpathak sanketpathak force-pushed the gherkin_script_pipeline_metrics_ODC-3711 branch from abfa1d0 to 48016da Compare December 10, 2020 09:46
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@gajanan-more
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2020
@sanketpathak
Copy link
Contributor Author

/assign @makambalaji

@makambalaji
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gajanan-more, karthikjeeyar, makambalaji, sanketpathak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@openshift-merge-robot
Copy link
Contributor

@sanketpathak: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-console 48016da link /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit af9f0ae into openshift:master Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@sanketpathak: All pull requests linked via external trackers have merged:

Bugzilla bug 1905977 has been moved to the MODIFIED state.

In response to this:

Bug 1905977: Gherkin script pipeline metrics odc 3711

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@gajanan-more gajanan-more gajanan-more requested changes

@abhinandan13jan abhinandan13jan Awaiting requested review from abhinandan13jan

Assignees

@karthikjeeyar karthikjeeyar

@gajanan-more gajanan-more

@makambalaji makambalaji

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@sanketpathak @openshift-ci-robot @karthikjeeyar @gajanan-more @makambalaji @openshift-merge-robot @openshift-bot @spadgett