Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1907890: Fix to show correct alert when required in pipeline parameters and resources forms #7486

Merged
merged 1 commit into from Dec 16, 2020
Merged

Bug 1907890: Fix to show correct alert when required in pipeline parameters and resources forms #7486

merged 1 commit into from Dec 16, 2020

Conversation

divyanshiGupta
Copy link
Contributor

@divyanshiGupta divyanshiGupta commented Dec 9, 2020 •
edited

Fixes: https://issues.redhat.com/browse/ODC-5229

Analysis/Root cause:
Alert with misleading and incomplete message Click to save changes or to cancel changes was shown to the user after adding a empty row even though when Save button is disabled.
During FormFooter comp localization the comp was also refactored but other comps such as PipelineParametersForm and PipelineResourcesForm which are using FormFooter were not fixed accordingly by passing required labels to FormFooter comp to show correct alert message.

Solution:
Show alert only when the fields are changed and Save is enabled. This PR also adds resetLabel and submitLabel to show in the alert message which were missed during localization.

Screenshots:
image
image
image
image

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 9, 2020
rottencandy
rottencandy reviewed Dec 9, 2020
View reviewed changes
...ackages/pipelines-plugin/src/components/pipelines/detail-page-tabs/PipelineResourcesForm.tsx Outdated
@@ -5,6 +5,7 @@ import { FormikProps, FormikValues, getIn } from 'formik';
import { useAccessReview } from '@console/internal/components/utils';
import { FormFooter } from '@console/shared';
import PipelineResources from './PipelineResources';
import { useTranslation } from 'react-i18next';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: sort imports

rottencandy
rottencandy reviewed Dec 10, 2020
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is a bug, but if I delete an existing value and click add, the button gets disabled.
tmp

@divyanshiGupta
Copy link
Contributor Author

Not sure if this is a bug, but if I delete an existing value and click add, the button gets disabled.
tmp

@rottencandy it is supposed to work like that since any ways we don't allow saving an empty row and if the user has deleted a row and want to add another in its place either they have to add the required data or they can remove the empty row and then save and the new saved record will not have the deleted row.

rottencandy
rottencandy approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2020
@divyanshiGupta
Copy link
Contributor Author

/assign @rohitkrai03

rohitkrai03
rohitkrai03 approved these changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, rohitkrai03, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@divyanshiGupta divyanshiGupta changed the title Fix to show correct alert when required in pipeline parameters and resources forms Bug 1907890: Fix to show correct alert when required in pipeline parameters and resources forms Dec 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: This pull request references Bugzilla bug 1907890, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907890: Fix to show correct alert when required in pipeline parameters and resources forms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 15, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f65711d into openshift:master Dec 16, 2020
@openshift-ci-robot
Copy link
Contributor

@divyanshiGupta: All pull requests linked via external trackers have merged:

Bugzilla bug 1907890 has been moved to the MODIFIED state.

In response to this:

Bug 1907890: Fix to show correct alert when required in pipeline parameters and resources forms

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

@rottencandy rottencandy rottencandy approved these changes

@karthikjeeyar karthikjeeyar Awaiting requested review from karthikjeeyar

Assignees

@rohitkrai03 rohitkrai03

@rottencandy rottencandy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@divyanshiGupta @openshift-ci-robot @openshift-bot @rohitkrai03 @rottencandy @spadgett @openshift-merge-robot