Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2371: [i18n] Externalize strings in ./packages/operator-lifecycle-manager/src #7496

Merged
merged 1 commit into from Jan 8, 2021
Merged

CONSOLE-2371: [i18n] Externalize strings in ./packages/operator-lifecycle-manager/src #7496

merged 1 commit into from Jan 8, 2021

Conversation

TheRealJon
Copy link
Member

Externalize strings in files at root level of frontend/packages/operator-lifecycle-manager/src

@openshift-ci-robot openshift-ci-robot added the component/core Related to console core functionality label Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Dec 9, 2020
@spadgett
Copy link
Member

/assign

@spadgett spadgett changed the title [i18n] Externalize strings in ./packages/operator-lifecycle-manager/src CONSOLE-2371: [i18n] Externalize strings in ./packages/operator-lifecycle-manager/src Dec 10, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 10, 2020
@TheRealJon TheRealJon force-pushed the CONSOLE-2371-root branch 4 times, most recently from 763e330 to da924bb Compare December 11, 2020 17:00
@TheRealJon
Copy link
Member Author

/retest

1 similar comment
@rhamilto
Copy link
Member

/retest

rhamilto
rhamilto approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for approvals

/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2020
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Dec 15, 2020
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020
@TheRealJon TheRealJon force-pushed the CONSOLE-2371-root branch 2 times, most recently from b222cee to e638ada Compare December 17, 2020 20:24
@yapei
Copy link
Contributor

yapei commented Dec 21, 2020

@TheRealJon I've tested again and no more issues

@yapei
Copy link
Contributor

yapei commented Dec 21, 2020

/label qe-approved

@openshift-ci-robot openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Dec 21, 2020
@TheRealJon
Copy link
Member Author

/retest

@rhamilto
Copy link
Member

rhamilto commented Jan 5, 2021

@TheRealJon rebase required.

@TheRealJon
Copy link
Member Author

/assign @sferich888

@TheRealJon
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 5, 2021 •
edited

@TheRealJon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 3dd62b4 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@TheRealJon
Copy link
Member Author

/retest

spadgett
spadgett approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 5, 2021
@reestr
Copy link

reestr commented Jan 6, 2021

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Jan 6, 2021
@spadgett spadgett added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@spadgett
Copy link
Member

spadgett commented Jan 6, 2021

/hold cancel

@TheRealJon FYI, needs rebase

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2021
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 6, 2021
@TheRealJon
Copy link
Member Author

@spadgett rebased. Needs lgtm again.

spadgett
spadgett approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 7, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 76840d4 into openshift:master Jan 8, 2021
@spadgett spadgett added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 8, 2021
@TheRealJon TheRealJon deleted the CONSOLE-2371-root branch January 22, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yapei yapei yapei left review comments

@rhamilto rhamilto rhamilto approved these changes

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@TheRealJon @spadgett @rhamilto @ahardin-rh @yapei @reestr @openshift-ci-robot @sferich888 @openshift-merge-robot