Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-2371: [i18n] Externalize strings in olm root components #7497

Merged
merged 1 commit into from Jan 8, 2021
Merged

CONSOLE-2371: [i18n] Externalize strings in olm root components #7497

merged 1 commit into from Jan 8, 2021

Conversation

TheRealJon
Copy link
Member

Externalize strings in files at root level of frontend/packages/operator-lifecycle-manager/src/components

@openshift-ci-robot openshift-ci-robot added the component/olm Related to OLM label Dec 9, 2020
@openshift-ci-robot openshift-ci-robot added the component/shared Related to console-shared label Dec 9, 2020
@spadgett spadgett changed the title [i18n] Externalize strings in olm root components CONSOLE-2371: [i18n] Externalize strings in olm root components Dec 10, 2020
@spadgett spadgett added this to the v4.7 milestone Dec 10, 2020
spadgett
spadgett reviewed Dec 10, 2020
View reviewed changes
frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/clusterserviceversion.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/create-catalog-source.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/install-plan.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/install-plan.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated Show resolved Hide resolved
frontend/packages/operator-lifecycle-manager/src/components/subscription.tsx Outdated Show resolved Hide resolved
@spadgett spadgett self-assigned this Dec 10, 2020
@TheRealJon TheRealJon force-pushed the CONSOLE-2371-components branch 3 times, most recently from ac6745b to 55f37af Compare December 11, 2020 17:45
@TheRealJon
Copy link
Member Author

/retest

rhamilto
rhamilto approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great code improvements!

/lgtm

/hold for approvals

/assign @yapei @ahardin-rh @sferich888

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 14, 2020
@ahardin-rh
Copy link

/label docs-approved

@openshift-ci-robot openshift-ci-robot added the docs-approved Signifies that Docs has signed off on this PR label Dec 15, 2020
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

@spadgett I've addressed your comments

@reestr
Copy link

reestr commented Jan 6, 2021

/label px-approved

@openshift-ci-robot openshift-ci-robot added the px-approved Signifies that Product Support has signed off on this PR label Jan 6, 2021
@reestr
Copy link

reestr commented Jan 6, 2021

/label px-approved

@spadgett spadgett added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2021
@TheRealJon TheRealJon force-pushed the CONSOLE-2371-components branch 3 times, most recently from f7f8555 to e67ffe0 Compare January 7, 2021 14:44
@TheRealJon
Copy link
Member Author

@spadgett rebased. Needs lgtm again.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 7, 2021 •
edited

@TheRealJon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/kubevirt-plugin 12746f2 link /test kubevirt-plugin

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Jan 8, 2021
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 8, 2021
spadgett
spadgett approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @TheRealJon !

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TheRealJon TheRealJon mentioned this pull request Jan 8, 2021
Merged
@openshift-merge-robot openshift-merge-robot merged commit 314d892 into openshift:master Jan 8, 2021
@TheRealJon TheRealJon deleted the CONSOLE-2371-components branch January 22, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yapei yapei yapei left review comments

@rhamilto rhamilto rhamilto approved these changes

@spadgett spadgett spadgett approved these changes

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@rhamilto rhamilto

@spadgett spadgett

@yapei yapei

@ahardin-rh ahardin-rh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/olm Related to OLM component/shared Related to console-shared docs-approved Signifies that Docs has signed off on this PR kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@TheRealJon @ahardin-rh @openshift-merge-robot @yapei @spadgett @rhamilto @reestr @openshift-ci-robot @sferich888