Bug 1908035: Fix issue with dynamic-demo-plugin webpack build

[vojtechszocs]

Console dynamic plugin SDK (and consequently dynamic-demo-plugin) currently uses webpack 5.0.0-beta.16 which doesn't support empty entry object yet. Quote from webpack docs:

You can pass empty object {} to entry when you have only entrypoints generated by plugins.

This will be fixed once we bump dynamic plugin SDK dependencies.

In the meantime, this PR fixes an issue where dynamic-demo-plugin/dist wasn't generated at all due to changes made in #7163 (ConsoleAssetPlugin not using afterCompile hook).

---

Tech details: Dynamic plugin projects are not typical web applications with webpack-processed entry points. All dynamic plugin assets are generated via ConsoleRemotePlugin (which uses ConsoleAssetPlugin under the hood). However, webpack 4 requires us to specify at least one entry point (from which a bundle gets created). We're currently working around this issue, with webpack 5 latest this should be a non-issue.

[spadgett]

If we move to the latest beta, v5.0.0-beta.31, would that address the issue?

[vojtechszocs]

If we move to the latest beta, v5.0.0-beta.31, would that address the issue?

@spadgett I'd suggest moving to latest v5 stable (currently 5.10.0) since there's been a lot of changes around module federation code between 5.0.0-beta.16 and the latest beta anyway.

Edit: The move to webpack v5 stable for dynamic plugin SDK & demo plugin would be done in a separate PR. This PR is only to fix the immediate issue.

[openshift-ci-robot]

@vojtechszocs: This pull request references Bugzilla bug 1908035, which is invalid:

• expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1908035: Fix issue with dynamic-demo-plugin webpack build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/bugzilla refresh

[openshift-ci-robot]

@jhadvig: This pull request references Bugzilla bug 1908035, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jhadvig]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/console-dynamic-plugin-sdk/OWNERS [jhadvig,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vojtechszocs: All pull requests linked via external trackers have merged:

• openshift/console#7516

Bugzilla bug 1908035 has been moved to the MODIFIED state.

In response to this:

Bug 1908035: Fix issue with dynamic-demo-plugin webpack build

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.