Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1906685: show sinkbinding as resources in sidebar if owned by source #7520

Merged
merged 1 commit into from Dec 15, 2020
Merged

Bug 1906685: show sinkbinding as resources in sidebar if owned by source #7520

merged 1 commit into from Dec 15, 2020

Conversation

invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Dec 11, 2020 •
edited

Fixes:
https://issues.redhat.com/browse/ODC-5228

Analysis / Root cause:
SinkBinding is shown in topology view along with actual source created in case of Container source and KameletBinding Creation

Solution Description:
Show show only actual source created in topology view and sinkbinding in sidebar resources here (as is underlying resource here)

Unit test coverage report:

image

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2020
@invincibleJai invincibleJai changed the title show sinkibinding as resources if owned by source show sinkibinding as resources in sidebar if owned by source Dec 11, 2020
@invincibleJai invincibleJai changed the title show sinkibinding as resources in sidebar if owned by source Bug 1906685: show sinkbinding as resources in sidebar if owned by source Dec 11, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 11, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: This pull request references Bugzilla bug 1906685, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906685: show sinkbinding as resources in sidebar if owned by source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

karthikjeeyar
karthikjeeyar reviewed Dec 15, 2020
View reviewed changes
frontend/packages/knative-plugin/src/components/overview/EventSourceResources.tsx Outdated
};

const EventSinkServicesOverviewList: React.FC<EventSinkServicesOverviewListProps> = ({ obj }) => {
export const OwnedSourcesList: React.FC<{ source: K8sResourceKind }> = ({ source }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to have one component per file. Moving this out to new a file and we can then add its own test cases.

frontend/packages/knative-plugin/src/topology/knative-topology-utils.ts Outdated Show resolved Hide resolved
@karthikjeeyar
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4446516 into openshift:master Dec 15, 2020
@openshift-ci-robot
Copy link
Contributor

@invincibleJai: All pull requests linked via external trackers have merged:

Bugzilla bug 1906685 has been moved to the MODIFIED state.

In response to this:

Bug 1906685: show sinkbinding as resources in sidebar if owned by source

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spadgett spadgett added this to the v4.7 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@andrewballantyne andrewballantyne Awaiting requested review from andrewballantyne

@rottencandy rottencandy Awaiting requested review from rottencandy

Assignees

@karthikjeeyar karthikjeeyar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v4.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@invincibleJai @openshift-ci-robot @karthikjeeyar @spadgett @openshift-merge-robot