New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1906864: Fix vertical spacing for quick start tour failed error box #7527
Conversation
/kind bug |
/lgtm |
LGTM! |
/retitle Bug 1906864: Fix vertical spacing for quick start tour failed error box |
@vikram-raj: This pull request references Bugzilla bug 1906864, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @rohitkrai03 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: karthikjeeyar, rohitkrai03, vikram-raj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@vikram-raj: All pull requests linked via external trackers have merged: Bugzilla bug 1906864 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-4718
Analysis / Root cause:
Check your work part in the Quick Starts in not equally spaced. There is too much space between radio buttons and "Is the status Succeeded?" and there isn't any space between radio buttons and "Try walking through the steps again to properly install Pipelines Operator" when user selects "No" radio button. There is a lot space wasted after "Try walking through the steps again to properly install Pipelines Operator"
Solution Description:
Fix exact height for SyncMarkdownView.
Screen shots / Gifs for design review: