New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1907883: Fix Pipleine creation without namespace issue #7530
Bug 1907883: Fix Pipleine creation without namespace issue #7530
Conversation
/test analyze |
/approve |
Verified locally, works fine for me. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@karthikjeeyar: This pull request references Bugzilla bug 1907883, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@karthikjeeyar: All pull requests linked via external trackers have merged: Bugzilla bug 1907883 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes:
https://issues.redhat.com/browse/ODC-5251
Analysis / Root cause:
In pipeline builder yaml view, adding a pipeline yaml without a namespace is failing to create the pipeline with
not found
error.Solution Description:
If a namespace is not provided in the yaml view, then adding the active namespace on the form submission.
Screen shots / Gifs for design review:
Unit test coverage report:
Test setup:
Install pipelines operator -> go to pipeline builder yaml view -> add a template without the namespace and click create.
Browser conformance: