Bug 1907282: fix topology page white screen, use ternary operator instead of logical operator

[sahil143]

Fixes: https://issues.redhat.com/browse/ODC-5258

Analysis / Root cause:
We are using logical operator in the PodSet component which causes it to pass a boolean value to PodStatus component title/subtitle and since we started to truncate the title/subtitle using _.truncate in PodStatus component with PR #7447, boolean values are converted to string by lodash truncate false => 'false'.

Solution Description: use ternary operator instead of logical operator and pass undefined if showPodCount is false

Screen shots / Gifs for design review:

NO UI changes

Unit test coverage report:

Test setup:

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[sahil143]

/cc @jeff-phillips-18

[openshift-ci-robot]

@sahil143: This pull request references Bugzilla bug 1907282, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907282: fix topology page white screen, use ternary operator instead of logical operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@sahil143: This pull request references Bugzilla bug 1907282, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.7.0) matches configured target release for branch (4.7.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1907282: fix topology page white screen, use ternary operator instead of logical operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[karthikjeeyar]

/lgtm

[rohitkrai03]

/assign

[rohitkrai03]

/approve

The changes in the PR works fine to fix the issue and does make sense but I would like to point out that the analysis/root cause in the description mentions that the issue is caused because boolean value is being passed to _.truncate and it's changing false => 'false'. But that wouldn't break the UI since the prop accepts a string as valid type, so the main issue was being caused because false was being passed to titleComponent prop. Its fixed after these changes because now titleComponent receives undefined instead of false. cc: @sahil143

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, rohitkrai03, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/packages/console-shared/OWNERS [rohitkrai03]
• frontend/packages/topology/OWNERS [rohitkrai03]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sahil143]

so the main issue was being caused because false was being passed to titleComponent prop. Its fixed after these changes because now titleComponent receives undefined instead of false

Agreed, titleComponent wasn't being invoked since title itself was a boolean false and since translate converted it to a string it became true and titleComponent was invoked which was a boolean and not a component.

[openshift-ci-robot]

@sahil143: All pull requests linked via external trackers have merged:

• openshift/console#7534

Bugzilla bug 1907282 has been moved to the MODIFIED state.

In response to this:

Bug 1907282: fix topology page white screen, use ternary operator instead of logical operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.